After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733554 - search loupes in sidebar takes up precious space
search loupes in sidebar takes up precious space
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-22 11:41 UTC by Andreas Nilsson
Modified: 2014-09-01 19:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not show loupe in route PlaceEntries (1.75 KB, patch)
2014-09-01 07:39 UTC, Jonas Danielsson 		needs-work Details | Review
placeEntry: Add 'loupe' property (869 bytes, patch)
2014-09-01 18:09 UTC, Jonas Danielsson 		committed Details | Review
Only use the loupe icon on the main search (1.17 KB, patch)
2014-09-01 18:09 UTC, Jonas Danielsson 		committed Details | Review

Description Andreas Nilsson 2014-07-22 11:41:38 UTC 
The search loupe icons in the from and to takes up precious space that can be used to show locations that can sometimes be quite long. Google maps and a lot of other map services seems to do fine without these, so I think it's better to stick closer to the mockup and not have them here either.
Comment 1 Jonas Danielsson 2014-08-04 15:30:56 UTC 
Sounds fine.

The small trouble is we use the GtkSearchEntry (that has the loupe) in our PlaceEntry class  in both sidebar and the main search. I gather you want the loupe to stay in the main search bar?
Comment 2 Andreas Nilsson 2014-08-04 15:32:41 UTC 
(In reply to comment #1)
> Sounds fine.
> 
> The small trouble is we use the GtkSearchEntry (that has the loupe) in our
> PlaceEntry class  in both sidebar and the main search. I gather you want the
> loupe to stay in the main search bar?

Yep!
Comment 3 Jonas Danielsson 2014-09-01 07:39:54 UTC 
Created attachment 284978 [details] [review]
Do not show loupe in route PlaceEntries

How about something like this?
Comment 4 Zeeshan Ali 2014-09-01 15:31:22 UTC 
Review of attachment 284978 [details] [review]:

Being a nitpicker, I'll suggest to divide it into two patches. One to add the new prop, the other to use it.
Comment 5 Jonas Danielsson 2014-09-01 18:09:17 UTC 
Created attachment 285046 [details] [review]
placeEntry: Add 'loupe' property

Add a property that controls whether to show the loupe
icon in the GtkSearchEntry or not.
Comment 6 Jonas Danielsson 2014-09-01 18:09:21 UTC 
Created attachment 285047 [details] [review]
Only use the loupe icon on the main search

Do not display the loupe icon on the route planning
PlaceEntries.
Comment 7 Jonas Danielsson 2014-09-01 19:21:59 UTC 
Attachment 285046 [details] pushed as 1cafcc4 - placeEntry: Add 'loupe' property
Attachment 285047 [details] pushed as 00c24a2 - Only use the loupe icon on the main search