After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733539 - rtph264pay: append profile-level-id parameter to SDP if available
rtph264pay: append profile-level-id parameter to SDP if available
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
1.4.0
Other Linux
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-22 09:39 UTC by Srimanta Panda (trollkarlen)
Modified: 2014-08-01 15:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Append profile-level-id to SDP (874 bytes, patch)
2014-07-22 13:22 UTC, Srimanta Panda (trollkarlen) 		none Details | Review
Append profile-level-id to SDP (1.62 KB, patch)
2014-07-25 11:11 UTC, Srimanta Panda (trollkarlen) 		committed Details | Review

Description Srimanta Panda (trollkarlen) 2014-07-22 09:39:38 UTC 
Currently SDP parameter for describe request doesn't contains the profile-level id.

The profile level id is already present, but just need to append to the caps.
Comment 1 Srimanta Panda (trollkarlen) 2014-07-22 09:40:54 UTC 
I am currently working on it.
Comment 2 Srimanta Panda (trollkarlen) 2014-07-22 13:22:04 UTC 
Created attachment 281382 [details] [review]
Append profile-level-id to SDP
Comment 3 Tim-Philipp Müller 2014-07-24 12:50:21 UTC 
Looks fine to me, but I'm not sure if ->profile is always a valid profile-level-id, I think there are more checks needed there. For example, it only appears to be extracted/set if the input is AVC format, but not in case of byte-stream input.

Please also add a 'rtph264pay:' prefix to your commit message summary line and add the bug url as last line in the commit message body, thanks!
Comment 4 Srimanta Panda (trollkarlen) 2014-07-25 11:11:55 UTC 
Created attachment 281687 [details] [review]
Append profile-level-id to SDP
Comment 5 Tim-Philipp Müller 2014-08-01 15:04:30 UTC 
Pushed with minor style change (use != 0 to compare integer for non-0), thanks:

commit dd9f7168927239fe37244aba33ec618ddb9e4872
Author: Srimanta Panda <srimanta@axis.com>
Date:   Tue Jul 22 13:24:09 2014 +0200

    rtph264pay: append profile-level-id to SDP
    
    Append profile-level-id to SDP if available.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=733539