GNOME Bugzilla – Bug 733526
rhythmbox / audioscrobbler fails if built from separate build dir
Last modified: 2014-08-03 06:57:17 UTC
sid@unstable:~/build/git-build/rhythmbox/plugins/audioscrobbler$ make /usr/bin/intltool-merge /home/sid/source/git/rhythmbox/po /home/sid/source/git/rhythmbox/plugins/audioscrobbler/audioscrobbler.plugin.in audioscrobbler.plugin -d -u -c ../../po/.intltool-merge-cache Generating and caching the translation database Merging translations into audioscrobbler.plugin. make all-am make[1]: Entering directory '/local/packages/build/git-build/rhythmbox/plugins/audioscrobbler' CC libaudioscrobbler_la-rb-audioscrobbler-plugin.lo CC libaudioscrobbler_la-rb-audioscrobbler-entry.lo CC libaudioscrobbler_la-rb-audioscrobbler-profile-page.lo CC libaudioscrobbler_la-rb-audioscrobbler-account.lo CC libaudioscrobbler_la-rb-audioscrobbler-service.lo CC libaudioscrobbler_la-rb-audioscrobbler-user.lo CC libaudioscrobbler_la-rb-audioscrobbler.lo /home/sid/source/git/rhythmbox/plugins/audioscrobbler/rb-audioscrobbler.c:57:24: fatal error: rb-marshal.h: No such file or directory #include "rb-marshal.h" ^ compilation terminated. Makefile:703: recipe for target 'libaudioscrobbler_la-rb-audioscrobbler.lo' failed make[1]: *** [libaudioscrobbler_la-rb-audioscrobbler.lo] Error 1 make[1]: Leaving directory '/local/packages/build/git-build/rhythmbox/plugins/audioscrobbler' Makefile:549: recipe for target 'all' failed make: *** [all] Error 2
Created attachment 281354 [details] [review] Fix: Add missing build lib dir to include path diff -r 9e660529ac85 rhythmbox/plugins/audioscrobbler/Makefile.am --- a/rhythmbox/plugins/audioscrobbler/Makefile.am Tue Jul 22 05:14:05 2014 +0530 +++ b/rhythmbox/plugins/audioscrobbler/Makefile.am Tue Jul 22 05:15:21 2014 +0530 @@ -47,6 +47,7 @@ -I$(top_srcdir)/podcast \ -I$(top_srcdir)/plugins \ -I$(top_srcdir)/shell \ + -I$(top_builddir)/lib \ -DPIXMAP_DIR=\""$(datadir)/pixmaps"\" \ -DSHARE_DIR=\"$(pkgdatadir)\" \ -DDATADIR=\""$(datadir)"\" \
fixed in commit dc6edc1, but not the way you suggested. In general there's no need to use custom marshallers, so we don't need rb-marshal.h in most places.