After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733494 - flvdemux: build index when upstream is in pull mode
flvdemux: build index when upstream is in pull mode
Status: RESOLVED NOTABUG
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-21 11:32 UTC by Jan Alexander Steffens (heftig)
Modified: 2014-08-11 08:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (1.39 KB, patch)
2014-07-21 11:32 UTC, Jan Alexander Steffens (heftig) 		rejected Details | Review

Description Jan Alexander Steffens (heftig) 2014-07-21 11:32:09 UTC 
Created attachment 281304 [details] [review]
patch

In order to seek FLV streams, flvdemux creates a seek index;
however, this index is not created if upstream is not seekable.
gst_flv_demux_check_seekability was copied nearly verbatim from
GstBaseParse.

This commit allows flvdemux to build the index when upstream
is in pull mode, not just when upstream is seekable. This allows
timeshifting of live RTMP streams when using queue2 in download
or ringbuffer mode:

rtmpsrc ! queue2 ! flvdemux

Alternatively, queue2 could be altered to advertise seekability
downstream. I am unsure what is the best approach.
Comment 1 Jan Alexander Steffens (heftig) 2014-07-21 11:33:19 UTC 
A patch for the mentioned alternative is at #733351.
Comment 2 Jan Alexander Steffens (heftig) 2014-08-07 13:28:50 UTC 
Any comment?
Comment 3 Sebastian Dröge (slomo) 2014-08-11 08:38:26 UTC 
Comment on attachment 281304 [details] [review]
patch

It should only build an index if upstream is seekable, no matter if it's running in pull mode or push mode
Comment 4 Sebastian Dröge (slomo) 2014-08-11 08:39:08 UTC 
Let's fix queue2 instead :)