After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733476 - repofile: Avoid segfault if querying child in non-directory
repofile: Avoid segfault if querying child in non-directory
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-21 02:35 UTC by Colin Walters
Modified: 2014-07-21 12:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
repofile: Avoid segfault if querying child in non-directory (1.18 KB, patch)
2014-07-21 02:35 UTC, Colin Walters 		none Details | Review
repofile: Avoid segfault if querying child in non-directory (1.69 KB, patch)
2014-07-21 02:44 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2014-07-21 02:35:38 UTC 
The user might "ostree ls /usr/bin/bash/blah", which previously would
segfault.

A somewhat related future enhancement here would be for "ostree ls" to
follow symbolic links.

Reported-by: Dusty Mabe <dustymabe@gmail.com>
Comment 1 Colin Walters 2014-07-21 02:35:40 UTC 
Created attachment 281278 [details] [review]
repofile: Avoid segfault if querying child in non-directory
Comment 2 Colin Walters 2014-07-21 02:44:48 UTC 
Created attachment 281280 [details] [review]
repofile: Avoid segfault if querying child in non-directory

Now with test case ;)
Comment 3 Jasper St. Pierre (not reading bugmail) 2014-07-21 11:53:58 UTC 
Review of attachment 281280 [details] [review]:

OK.
Comment 4 Colin Walters 2014-07-21 12:00:38 UTC 
Attachment 281280 [details] pushed as cdaa951 - repofile: Avoid segfault if querying child in non-directory