After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733452 - core: Unify object deletion code with prune
core: Unify object deletion code with prune
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-20 12:36 UTC by Colin Walters
Modified: 2014-07-20 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
core: Unify object deletion code with prune (3.70 KB, patch)
2014-07-20 12:36 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2014-07-20 12:36:49 UTC 
The prune API duplicated logic to delete objects, and furthermore the
core API to delete an object didn't clean up detached metadata.

Fix the duplication by doing the obvious thing: prune should call
_delete.
Comment 1 Colin Walters 2014-07-20 12:36:51 UTC 
Created attachment 281234 [details] [review]
core: Unify object deletion code with prune
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-07-20 12:51:27 UTC 
Review of attachment 281234 [details] [review]:

Makes sense.
Comment 3 Colin Walters 2014-07-20 12:57:54 UTC 
Attachment 281234 [details] pushed as 72da2e0 - core: Unify object deletion code with prune