After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733435 - Make the board expand on large screens.
Make the board expand on large screens.
Status: RESOLVED FIXED
Product: gnome-sudoku
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-sudoku-maint
gnome-sudoku-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-20 03:01 UTC by Arnaud B.
Modified: 2014-07-21 02:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make the board expand on large screens. (1.57 KB, patch)
2014-07-20 03:01 UTC, Arnaud B.
none Details | Review
Make the board expand on large screens. (1.86 KB, patch)
2014-07-20 03:26 UTC, Arnaud B.
none Details | Review
Make the board expand on large screens. (5.70 KB, patch)
2014-07-20 04:46 UTC, Arnaud B.
reviewed Details | Review
Better use of the gnome-sudoku.ui file. (6.81 KB, patch)
2014-07-20 07:04 UTC, Arnaud B.
committed Details | Review
Use GtkStack to switch between board and new-game screen. (5.79 KB, patch)
2014-07-20 15:24 UTC, Arnaud B.
committed Details | Review

Description Arnaud B. 2014-07-20 03:01:29 UTC
Created attachment 281217 [details] [review]
Make the board expand on large screens.

When maximizing the window, the board should expand, to be correctly usable on a large screen (and on a touch one, but that’s another story…). Here is a minimalistic patch for doing that.
Comment 1 Arnaud B. 2014-07-20 03:26:17 UTC
Created attachment 281218 [details] [review]
Make the board expand on large screens.

Oops, old patch, this one also centers the start_box.
Comment 2 Arnaud B. 2014-07-20 04:46:02 UTC
Created attachment 281220 [details] [review]
Make the board expand on large screens.

Here is a probably better way to do the switch between the two states, using a GtkStack. As it replaces quite all the content of the previous patch, I prefer obsolete it.
Comment 3 Arnaud B. 2014-07-20 07:04:19 UTC
Created attachment 281223 [details] [review]
Better use of the gnome-sudoku.ui file.

Here is a second patch, using a little more the gnome-sudoku.ui file, that helps managing the controls_box when changing the window size.
Comment 4 Michael Catanzaro 2014-07-20 14:22:46 UTC
Review of attachment 281220 [details] [review]:

We just need a better commit message here, maybe something like:

"Use GtkStack to switch between board and new game screen

Also, make sure the board expands to fill the window when the window is large."
Comment 5 Michael Catanzaro 2014-07-20 14:24:10 UTC
Review of attachment 281223 [details] [review]:

Good
Comment 6 Arnaud B. 2014-07-20 15:24:05 UTC
Created attachment 281240 [details] [review]
Use GtkStack to switch between board and new-game screen.

Just changed the commit message.
Comment 7 Michael Catanzaro 2014-07-21 02:58:18 UTC
Thanks