After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733409 - d3dvideosink fails to build
d3dvideosink fails to build
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.x
Other Windows
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-19 16:24 UTC by LRN
Modified: 2014-07-19 21:55 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description LRN 2014-07-19 16:24:40 UTC
d3dhelpers.c: In function 'd3d_set_window_handle':
d3dhelpers.c:1088:5: error: passing argument 3 of 'PostMessageA' makes integer from pointer without a cast [-Werror]
     PostMessage (sink->d3d.window_handle, WM_QUIT_THREAD, NULL, NULL);
     ^
In file included from f:\gstreamer-buildslave\mingw\include\windows.h:72:0,
                 from d3dhelpers.h:27,
                 from d3dvideosink.h:30,
                 from d3dhelpers.c:26:
f:\gstreamer-buildslave\mingw\include\winuser.h:1886:29: note: expected 'WPARAM' but argument is of type 'void *'
   WINUSERAPI WINBOOL WINAPI PostMessageA(HWND hWnd,UINT Msg,WPARAM wParam,LPARAM lParam);
                             ^
d3dhelpers.c:1088:5: error: passing argument 4 of 'PostMessageA' makes integer from pointer without a cast [-Werror]
     PostMessage (sink->d3d.window_handle, WM_QUIT_THREAD, NULL, NULL);
     ^
In file included from f:\gstreamer-buildslave\mingw\include\windows.h:72:0,
                 from d3dhelpers.h:27,
                 from d3dvideosink.h:30,
                 from d3dhelpers.c:26:
f:\gstreamer-buildslave\mingw\include\winuser.h:1886:29: note: expected 'LPARAM' but argument is of type 'void *'
   WINUSERAPI WINBOOL WINAPI PostMessageA(HWND hWnd,UINT Msg,WPARAM wParam,LPARAM lParam);
                             ^
d3dhelpers.c: In function 'd3d_internal_window_thread':
d3dhelpers.c:2130:8: error: unused variable 'fGetMsg' [-Werror=unused-variable]
   BOOL fGetMsg;
        ^
d3dhelpers.c: In function 'd3d_hidden_window_thread':
d3dhelpers.c:2613:5: error: passing argument 3 of 'PostMessageA' makes integer from pointer without a cast [-Werror]
     PostMessage (hWnd, WM_DESTROY, NULL, NULL);
     ^
In file included from f:\gstreamer-buildslave\mingw\include\windows.h:72:0,
                 from d3dhelpers.h:27,
                 from d3dvideosink.h:30,
                 from d3dhelpers.c:26:
f:\gstreamer-buildslave\mingw\include\winuser.h:1886:29: note: expected 'WPARAM' but argument is of type 'void *'
   WINUSERAPI WINBOOL WINAPI PostMessageA(HWND hWnd,UINT Msg,WPARAM wParam,LPARAM lParam);
                             ^
d3dhelpers.c:2613:5: error: passing argument 4 of 'PostMessageA' makes integer from pointer without a cast [-Werror]
     PostMessage (hWnd, WM_DESTROY, NULL, NULL);
     ^
In file included from f:\gstreamer-buildslave\mingw\include\windows.h:72:0,
                 from d3dhelpers.h:27,
                 from d3dvideosink.h:30,
                 from d3dhelpers.c:26:
f:\gstreamer-buildslave\mingw\include\winuser.h:1886:29: note: expected 'LPARAM' but argument is of type 'void *'
   WINUSERAPI WINBOOL WINAPI PostMessageA(HWND hWnd,UINT Msg,WPARAM wParam,LPARAM lParam);
                             ^
cc1.exe: all warnings being treated as errors
Comment 1 Sebastian Dröge (slomo) 2014-07-19 16:56:36 UTC
These should all be fixed since 1.3.91 already:

commit 28d250ec3f5463d801b1112794d6f0f22a36e61d
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Wed Jul 2 10:01:34 2014 +0200

    d3dvideosink: PostMessage() takes integers as last parameters, not pointers

commit 677608bfb71c3dc5b1d4608b4fa24f2480df31e3
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Wed Jul 2 09:59:02 2014 +0200

    d3dvideosink: Remove unused variable


At least I didn't get any more compiler warnings after that.
Comment 2 LRN 2014-07-19 21:55:22 UTC
My bad. Indeed, this particular issue is already fixed.