GNOME Bugzilla – Bug 733395
rtsp-client: add overridable generic handle_request and handle_data vmethods
Last modified: 2018-11-03 15:38:00 UTC
Created attachment 281175 [details] RTSP msgs on miracast I'm just starting to implement wifi display based on gst-rtsp-server. There are some rtsp msgs based on wifi display spec, which means that i need to implement new handling logic for these msgs. Of course I can handle these msgs by creating new method. But I think overriding handle_request in rtsp-client class would be better. Please find the attached file, miracast rtsp msgs to be more easy to understand. And also attached patch. Could you review this?
Created attachment 281176 [details] [review] Patch to add handle_request,handle_data vmethod I add 2 vmethods, handle_request, handle_data. For handle_response, I think I can handle by signal SIGNAL_HANDLE_RESPONSE.
Created attachment 291362 [details] [review] Rebased
Created attachment 291376 [details] [review] Change commit msg, rebased
Comment on attachment 281176 [details] [review] Patch to add handle_request,handle_data vmethod Please mark the previous patch obsolete with your new iterations.
Ok I'll keep in mind
Is this still needed or can it be closed? There quite a few of new signals and vfuncs added since. I think you'd have to be a bit more specific and explain what exactly you can't handle with the current API/mechanisms. Note also that you can't just add vfuncs in the middle of a public class structure, that breaks ABI compatibility, and you will also have to reduce the padding when you add new stuff into the public structure, to keep the struct size the same as before.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-rtsp-server/issues/3.