Bug 733392 – Compilation Error: implicit declaration of function ‘gtk_application_set_accels_for_action’ in shell/ev-application.c

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 733392 - Compilation Error: implicit declaration of function ‘gtk_application_set_accels_for_action’ in shell/ev-application.c


Summary:	Compilation Error: implicit declaration of function ‘gtk_application_set_acce...


Status:	RESOLVED FIXED

Product:	evince
Classification:	Core
Component:	general
Version:	3.13.x
Hardware:	Other Linux

Importance:	Normal major
Target Milestone:	---
Assigned To:	Evince Maintainers
QA Contact:	Evince Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2014-07-19 10:04 UTC by Jean-Christophe Manciot
Modified:	2014-07-21 15:24 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
Bump Gtk+ requirements to 3.12 (696 bytes, patch) 2014-07-21 08:22 UTC, José Aliste	committed	Details \| Review

Description Jean-Christophe Manciot 2014-07-19 10:04:29 UTC

Ubuntu 14.04 - Evince 3.13.3

Make error:
CC       evince-ev-application.o
ev-application.c: In function ‘ev_application_startup’:
ev-application.c:1075:17: error: implicit declaration of function ‘gtk_application_set_accels_for_action’ [-Werror=implicit-function-declaration]
                 gtk_application_set_accels_for_action (GTK_APPLICATION (application), it[0], &it[1]);
                 ^
ev-application.c:1075:17: warning: nested extern declaration of ‘gtk_application_set_accels_for_action’ [-Wnested-externs]
cc1: some warnings being treated as errors
make[3]: *** [evince-ev-application.o] Error 1
make[3]: Leaving directory `/home/actionmystique/Program-Files/Ubuntu/Evince/evince-3.13.3/shell'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/actionmystique/Program-Files/Ubuntu/Evince/evince-3.13.3/shell'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/actionmystique/Program-Files/Ubuntu/Evince/evince-3.13.3'
make: *** [all] Error 2

Comment 1 André Klapper 2014-07-19 14:09:59 UTC

Regression introduced by https://git.gnome.org/browse/evince/commit/shell/ev-application.c?id=8bb5fce0754aa0d2dc795d2d21ec778888dc3714

CC'ing author.

Comment 2 José Aliste 2014-07-21 06:42:44 UTC

mmm this is not a regression. we shoupd bump the requirements of gtk in master, so we make sure this function exists. Using a newer gtk should solve the compilation issue.

Comment 3 Jean-Christophe Manciot 2014-07-21 07:58:13 UTC

I have the latest version from official Ubuntu repos:
 libgtk-3-dev: 3.10.8

I shouldn't be necessary to install any other version.

Comment 4 José Aliste 2014-07-21 08:22:41 UTC

Created attachment 281282 [details] [review]
Bump Gtk+ requirements to 3.12

See

Comment 5 José Aliste 2014-07-21 08:25:04 UTC

Evince 3.13 is un UNSTABLE version. In fact, we only need Gtk+ 3.12 for this to properly compile. So, bumping requirements to Gtk+ 3.12.

Comment 6 Jean-Christophe Manciot 2014-07-21 08:30:55 UTC

Let us know when it becomes stable.

Comment 7 Carlos Garcia Campos 2014-07-21 12:28:11 UTC

Review of attachment 281282 [details] [review]:

Please explain why in the commit message. Thanks!

Comment 8 José Aliste 2014-07-21 15:23:49 UTC

Review of attachment 281282 [details] [review]:

Fixed commit message and pushed to master

Comment 9 José Aliste 2014-07-21 15:24:09 UTC

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.