GNOME Bugzilla – Bug 733374
Inline HeaderBar looks bad in theme with rounded corners
Last modified: 2014-07-23 02:25:15 UTC
Created attachment 281137 [details] Screenshot showing appearance in (a varient of) the Ambiance theme Some themes give HeaderBars rounded top corners. This doesn't look good when we use them for inline composers, since we're drawing a rectangular border and shadow behind them. (See attached screenshot.) This may be a bug in the theme. I note that in Adiawata, HeaderBars on Windows are rounded, but those in other widgets are not. There are several lines of attach we could use: - Modify the theming so that inline HeaderBars have sharp corners. - Detect the border radius in GTK and match it with the underlying HTML. - Don't draw the border and shadow in HTML, and do it in GTK instead.
Created attachment 281212 [details] [review] Force inline ComposerHeaderbar to have square corners This takes the first approach, modifying the GTK CSS to make HeaderBars that appear in Gtk.Alignments have square corners. It does this through a global style provider. I think we could also do this via a local style provider acting only on HeaderBars; I don't know if that'd be better or not. We may also want to see about making sure this is active when we're running under ENABLE_UNITY; I noticed that also looked bad with rounded corners under Ambiance.
Created attachment 281239 [details] [review] Force inline ComposerHeaderbar to have square corners This tweaks the CSS a bit to also catch the main window HeaderBar when we're running with ENABLE_UNITY. Rounded corners look even worse then.
Review of attachment 281239 [details] [review]: I'm fine with this approach. Commit!
Attachment 281239 [details] pushed as b6bcbb9 - Force inline ComposerHeaderbar to have square corners