After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733370 - Need a better symbolic icon for "Detach" for inline composer
Need a better symbolic icon for "Detach" for inline composer
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: composer
master
Other Linux
: Normal normal
: 0.8.0
Assigned To: Geary Maintainers
Geary Maintainers
review
Depends on:
Blocks:
 
 
Reported: 2014-07-18 16:35 UTC by Robert Schroll
Modified: 2014-07-19 21:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Idea for detach button (3.07 KB, image/svg+xml)
2014-07-18 16:35 UTC, Robert Schroll
  Details
New detach icon for inline composer (5.37 KB, patch)
2014-07-18 21:47 UTC, Robert Schroll
committed Details | Review

Description Robert Schroll 2014-07-18 16:35:39 UTC
Created attachment 281135 [details]
Idea for detach button

We're currently using "window-maximize-symbolic" for the "Detach" button, since that was closest in name to the action we mean to invoke.  But the icon is just a square, which isn't so meaningful.  We should come up with a better icon.

Yosef has suggested "view-fullscreen-symbolic" (https://git.gnome.org/browse/adwaita-icon-theme/plain/Adwaita/scalable/actions/view-fullscreen-symbolic.svg), which is a bit more evocative.  But if other applications use it to actually mean "Fullscreen", it may confuse users to use it in this context.

Jim suggested looking for an icon at the Noun Project; perhaps http://thenounproject.com/term/detach/28818/ or http://thenounproject.com/term/import/50957/.  I'm not sold on either of these, and I worry they'll look anemic next to the thicker style of the default symbolic icons.

I've attached a possibility I made by rotating the arrow of the "view-restore-symbolic" icon to point outwards.  It looks like the licensing on this is LGPLv3 or CC-SA3.  I'm assuming that's compatible with Geary, but we should check on the details if we like this icon.
Comment 1 Jim Nelson 2014-07-18 19:00:51 UTC
I like your icon; it expresses exactly what will happen if the user clicks on it.  It's better than the alternatives we have so far.

I believe we can include your icon under CC BY-SA 3.0 as long as we include an attribution and link to original in our COPYING.icons file:

https://creativecommons.org/licenses/by-sa/3.0/

I say let's go for it.
Comment 2 Robert Schroll 2014-07-18 21:47:42 UTC
Created attachment 281153 [details] [review]
New detach icon for inline composer

I think I've added everything that needs to be added, but I'm not sure 
of that.  There's some metadata in the SVG file that I haven't modified; 
I don't know if we should or not.
Comment 3 Jim Nelson 2014-07-18 23:20:45 UTC
Review of attachment 281153 [details] [review]:

I don't see anything too serious in the SVG metadata.  It lists it as part of the "Gnome Symbolic Icon Theme", which is fine by me.  That plus COPYING.icons I think satisfies licensing.

I'm sold.  Commit!
Comment 4 Robert Schroll 2014-07-19 21:19:03 UTC
Attachment 281153 [details] pushed as bc29652 - New detach icon for inline composer