After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733324 - skipping a frame in decode_picture() shouldn't stop the gst pipeline
skipping a frame in decode_picture() shouldn't stop the gst pipeline
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 720305
 
 
Reported: 2014-07-17 15:11 UTC by Fabrice Bellet
Modified: 2014-07-21 08:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
decoder: mpeg4: fix picture decoder return value (1.20 KB, patch)
2014-07-17 15:12 UTC, Fabrice Bellet 		committed Details | Review

Description Fabrice Bellet 2014-07-17 15:11:33 UTC 
Hi!

The frame skip could be handled gracefully by making decode_picture() return GST_VAAPI_DECODER_STATUS_DROP_FRAME instead of GST_VAAPI_DECODER_STATUS_ERROR_NO_DATA.

Without this patch, the pipeline stops with this error:

ERROR: from element /GstPipeline:pipeline0/GstMatroskaDemux:matroskademux0: GStreamer encountered a general stream error.
Comment 1 Fabrice Bellet 2014-07-17 15:12:33 UTC 
Created attachment 281015 [details] [review]
decoder: mpeg4: fix picture decoder return value
Comment 2 Gwenole Beauchesne 2014-07-21 08:18:32 UTC 
Review of attachment 281015 [details] [review]:

Applied to git master branch. Thanks.
Comment 3 Gwenole Beauchesne 2014-07-21 08:18:50 UTC 
commit 00ca734ebf4ea554588ff067f364ad4d3e383e42
Author: Fabrice Bellet <fabrice@bellet.info>
Date:   Thu Jul 17 01:51:36 2014 +0200

    decoder: mpeg4: fix picture decoder return value for skipped frames.
    
    The picture decoder should return GST_VAAPI_DECODER_STATUS_DROP_FRAME
    when a frame should be skipped, so the stream processing is not stalled.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=733324