After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733309 - Potential error in checking NetworkManager version
Potential error in checking NetworkManager version
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Network
git master
Other Linux
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-17 11:25 UTC by Felix Zhang
Modified: 2014-08-08 04:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A patch to fix the problem (1015 bytes, patch)
2014-07-17 11:31 UTC, Felix Zhang 		committed Details | Review

Description Felix Zhang 2014-07-17 11:25:32 UTC 
In g-c-c/panel/network/cc-network-panel.c:panel_check_network_manager_version()

The following code is probably erroneous:
        if (major > 0 || major > 9 || (minor <= 8 && micro < 992)) {
Comment 1 Felix Zhang 2014-07-17 11:31:30 UTC 
Created attachment 280961 [details] [review]
A patch to fix the problem
Comment 2 Bastien Nocera 2014-07-17 12:42:00 UTC 
Review of attachment 280961 [details] [review]:

Looks good.
Comment 3 Felix Zhang 2014-07-27 11:56:00 UTC 
(In reply to comment #2)
> Review of attachment 280961 [details] [review]:
> 
> Looks good.

Thank you very much for the review, will the fix be checked in the repo?
Comment 4 Bastien Nocera 2014-08-07 11:07:16 UTC 
Pushed to gnome-3-8, gnome-3-10, gnome-3-12 and master.
Comment 5 Felix Zhang 2014-08-08 04:02:16 UTC 
(In reply to comment #4)
> Pushed to gnome-3-8, gnome-3-10, gnome-3-12 and master.

Thanks!