After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733281 - ftp backend fails to set permissions in some cases
ftp backend fails to set permissions in some cases
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: ftp backend
1.21.x
Other Linux
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-16 21:39 UTC by Ross Lagerwall
Modified: 2014-07-17 16:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ftp: Only send permission bits for SITE CHMOD (1.29 KB, patch)
2014-07-16 21:47 UTC, Ross Lagerwall 		committed Details | Review

Description Ross Lagerwall 2014-07-16 21:39:08 UTC 
I noticed the following output when doing a gvfs-copy to an ftp mount:

Queued new job 0x226d5d0 (GVfsJobSetAttribute)
-- 0 ->  SITE CHMOD 100644 /path
<- 0 --  501 Invalid permissions
send_reply(0x226d5d0), failed=1 (Operation unsupported)

We should only send the permission bits.
Comment 1 Ross Lagerwall 2014-07-16 21:47:12 UTC 
Created attachment 280890 [details] [review]
ftp: Only send permission bits for SITE CHMOD

Some ftp servers give an error if more bits than just the permission
bits are sent for SITE CHMOD so only send the permission bits.
Comment 2 Ondrej Holy 2014-07-17 12:45:55 UTC 
Review of attachment 280890 [details] [review]:

Looks good to me, thanks!
Comment 3 Ross Lagerwall 2014-07-17 16:45:48 UTC 
Pushed to master as f1dbbb14162fe458b1f374ef888ffab9e15bc1ae. Thanks for the review!