After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733250 - Secondary selection toolbar is below player bar in selection mode
Secondary selection toolbar is below player bar in selection mode
Status: RESOLVED FIXED
Product: gnome-music
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal normal
: 3.14
Assigned To: gnome-music-maint
gnome-music-maint
Depends on:
Blocks: 733267
 
 
Reported: 2014-07-16 13:51 UTC by Lasse Schuirmann
Modified: 2014-11-22 09:13 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the described state (70.98 KB, image/png)
2014-07-16 13:54 UTC, Lasse Schuirmann
Details

Description Lasse Schuirmann 2014-07-16 13:51:25 UTC
(If someone has a better title for this bug please change it ;))
When entering selection mode the so called "secondary selection toolbar" (https://wiki.gnome.org/Design/OS/SelectionPattern) is below the bar where I can play/pause the music (see screenshot).

This doesn't really make sense to me since the player bar is a bit like a window border for me. I'd place this temporary toolbar over the other instead.

(This is hard to explain, if you don't understand what I mean, please say so and I'll try another explanation and a mockup.)
Comment 1 Lasse Schuirmann 2014-07-16 13:54:10 UTC
Created attachment 280834 [details]
Screenshot of the described state
Comment 2 Allan Day 2014-07-16 16:01:13 UTC
Showing the player bar and action bar simultaneously look bad indeed. My suggestion would be to hide the player bar when the action bar is displayed - it's a temporary, modal state, after all.
Comment 3 Lasse Schuirmann 2014-07-16 16:04:17 UTC
can't we combine the two bars instead of hiding the one with the controls? (I'd miss them because it's not like they're not contextually relevant.)

So add some controls and realign the others but ensure that multiple-song actions are seperated from the other "usual" ones.

If we can't agree on this I'd suggest not hiding one bar and showing another but rather hide the UI elements on the bar and replace them by the other ones, the other thing looks weird as I'm imagining it.
Comment 4 Allan Day 2014-07-16 16:20:40 UTC
(In reply to comment #3)
> can't we combine the two bars instead of hiding the one with the controls? (I'd
> miss them because it's not like they're not contextually relevant.)
> 
> So add some controls and realign the others but ensure that multiple-song
> actions are seperated from the other "usual" ones.

They're pretty different in scope and content. Not sure that would work conceptually or practically.

> If we can't agree on this I'd suggest not hiding one bar and showing another
> but rather hide the UI elements on the bar and replace them by the other ones,
> the other thing looks weird as I'm imagining it.

Yeah, we have to consider what the transition would look like here (this is somewhat dependent on whether the bars have different heights). One option would be to hide the player bar when selection mode is activated, and then slide up the action bar when an item is selected.
Comment 5 bidossessi.sodonon 2014-07-18 03:06:06 UTC
Hi.
https://wiki.gnome.org/Design/OS/SelectionPattern seems to want to establish "selection mode" as a modal paradigm: Start it, do what you have to do, get out.
It works the same way on Android. The only controls available in selection mode are selection actions. Once you're done, they disappear.

I think The action bar should cover/replace the bottom player controls.
If we are ready to hide the top navigation bar, I don't really see why hiding the bottom would be more jarring.

Regards.
Comment 6 Arnel Borja 2014-07-29 08:44:22 UTC
I think this is already fixed in master? If not, could anyone please provide the steps to reproduce it? I occasionally checks this problem and fixed some of those this cycle.
Comment 7 David Gumberg 2014-10-15 03:25:03 UTC
This is obsolete in 3.14 and possibly/probably earlier versions.
Comment 8 Arnel Borja 2014-11-22 09:13:44 UTC
Seems like it is already fixed in 3.14.