After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733242 - Fix issue of mem map
Fix issue of mem map
Status: RESOLVED DUPLICATE of bug 704078
Product: gstreamer-vaapi
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 733243
 
 
Reported: 2014-07-16 09:44 UTC by Fabrice Bellet
Modified: 2014-07-23 22:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Fabrice Bellet 2014-07-16 09:44:12 UTC 
I noticed this patch from tizen that seems to be required for my use case (vaapidecode ! videoconvert ! xvimagesink for example). When flags==GST_MAP_READ, this test fails.

https://build.tizen.org/package/view_file?expand=1&file=0001-Fix-issue-of-mem-map.patch&package=gstreamer-vaapi&project=Tizen%3AMobile
Comment 1 Gwenole Beauchesne 2014-07-22 17:05:09 UTC 
Hi,

(In reply to comment #0)
> I noticed this patch from tizen that seems to be required for my use case
> (vaapidecode ! videoconvert ! xvimagesink for example). When
> flags==GST_MAP_READ, this test fails.
> 
> https://build.tizen.org/package/view_file?expand=1&file=0001-Fix-issue-of-mem-map.patch&package=gstreamer-vaapi&project=Tizen%3AMobile

I am not convinced by this one. The correct condition I initially had in mind and really wanted to make "unsupported" was requested map-flags == R/W but no direct-rendering was supported.

There is a more general core GStreamer bug around to ensure that we deprecate plain R/W flags but rather have a notion of write-first+eventually-read or read-modify-write.
Comment 2 Gwenole Beauchesne 2014-07-23 17:31:39 UTC 
Marking it as duplicate of bug #704078 as R/W mappings are tracked here.

*** This bug has been marked as a duplicate of bug 704078 ***
Comment 3 Gwenole Beauchesne 2014-07-23 22:21:52 UTC 
commit c3643b42a44f57b76af95596383e3ff2f88c24be
Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Date:   Thu Jul 24 00:14:04 2014 +0200

    vaapivideomemory: forbid R/W mappings if non direct-rendering mode.
    
    Disable read-write mappings if "direct-rendering" is not supported.
    Since the ordering of read and write operations is not specified,
    this would require to always download the VA surface on _map(), then
    commit the temporary VA image back to the VA surface on _unmap().
    
    Some SW decoding plug-in elements still use R/W mappings though.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=733242