After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733216 - Action bar looks weird with a single icon button
Action bar looks weird with a single icon button
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
3.12.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-15 16:15 UTC by Allan Day
Modified: 2014-08-01 16:29 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
removed action bar and migrated the favorite button to header bar (11.60 KB, patch)
2014-07-30 12:54 UTC, Pranav Kant 		needs-work Details | Review
Removed action bar, migrated the favorite button to header bar (11.59 KB, patch)
2014-07-30 13:42 UTC, Debarshi Ray 		none Details | Review
Removed action bar, migrated the favorite button to header bar (12.14 KB, patch)
2014-07-30 15:27 UTC, Pranav Kant 		none Details | Review
Move the favorites button in the preview to the header bar (11.71 KB, patch)
2014-07-30 16:01 UTC, Debarshi Ray 		none Details | Review
Move the favorites button in the preview to the header bar (11.69 KB, patch)
2014-08-01 16:28 UTC, Debarshi Ray 		committed Details | Review

Description Allan Day 2014-07-15 16:15:09 UTC 
Right now the action bar spans the whole window width, but it only contains a tiny button in one corner. It looks a bit strange to have this much chrome for such a small control.

I'd move the star button to the header bar, until such a time as we grow a lot more actions.
Comment 1 Pranav Kant 2014-07-30 12:54:16 UTC 
Created attachment 282049 [details] [review]
removed action bar and migrated the favorite button to header bar

WIP patch.
Comment 2 Debarshi Ray 2014-07-30 13:41:35 UTC 
Review of attachment 282049 [details] [review]:

Thanks for the patch, Pranav.

::: src/photos-main-toolbar.c
@@ +757,3 @@
   priv->search = g_action_map_lookup_action (G_ACTION_MAP (app), "search");
 
+  priv->favorite_button = gd_header_toggle_button_new ();

We just use GtkToggleButton these days. See bug 733850

@@ +776,3 @@
+                            "active-changed",
+                            G_CALLBACK (photos_main_toolbar_active_changed),
+                            self);

Let's just use photos_main_toolbar_item_active_changed
Comment 3 Debarshi Ray 2014-07-30 13:42:26 UTC 
Created attachment 282060 [details] [review]
Removed action bar, migrated the favorite button to header bar

Resolved conflicts with master.
Comment 4 Pranav Kant 2014-07-30 15:27:49 UTC 
Created attachment 282082 [details] [review]
Removed action bar, migrated the favorite button to header bar
Comment 5 Debarshi Ray 2014-07-30 16:01:36 UTC 
Created attachment 282091 [details] [review]
Move the favorites button in the preview to the header bar
Comment 6 Debarshi Ray 2014-08-01 16:28:20 UTC 
Created attachment 282285 [details] [review]
Move the favorites button in the preview to the header bar

Removed an unused variable that had crept in.