After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733211 - [PATCHes] Add --version command-line option.
[PATCHes] Add --version command-line option.
Status: RESOLVED FIXED
Product: gnome-mahjongg
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-mahjongg-maint
gnome-mahjongg-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-15 15:38 UTC by Arnaud B.
Modified: 2014-07-17 13:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove white spaces. (9.14 KB, patch)
2014-07-15 15:38 UTC, Arnaud B. 		committed Details | Review
Add --version command-line option. (5.73 KB, patch)
2014-07-15 15:39 UTC, Arnaud B. 		reviewed Details | Review
Move calls from Mahjong() to startup(). (1.16 KB, patch)
2014-07-17 13:30 UTC, Arnaud B. 		committed Details | Review
Cosmetic move of code. (2.12 KB, patch)
2014-07-17 13:31 UTC, Arnaud B. 		committed Details | Review
Add --version command-line option. (3.80 KB, patch)
2014-07-17 13:31 UTC, Arnaud B. 		committed Details | Review

Description Arnaud B. 2014-07-15 15:38:43 UTC 
Created attachment 280731 [details] [review]
Remove white spaces.

It should be great to handle the standard --version command-line option. Here are two patches, the first is just some spaces-cleaning.
Comment 1 Arnaud B. 2014-07-15 15:39:09 UTC 
Created attachment 280732 [details] [review]
Add --version command-line option.
Comment 2 Michael Catanzaro 2014-07-17 00:40:50 UTC 
Review of attachment 280732 [details] [review]:

All the changes look fine

::: src/gnome-mahjongg.vala
@@ +35,3 @@
+    };
+
+    private const GLib.ActionEntry[] action_entries =

This should be moved in a separate patch

@@ +63,3 @@
 
+        add_action_entries (action_entries, this);
+        add_accelerator ("Pause", "app.pause", null);

These should be moved in a separate patch
Comment 3 Arnaud B. 2014-07-17 13:30:30 UTC 
Created attachment 280996 [details] [review]
Move calls from Mahjong() to startup().
Comment 4 Arnaud B. 2014-07-17 13:31:01 UTC 
Created attachment 280997 [details] [review]
Cosmetic move of code.
Comment 5 Arnaud B. 2014-07-17 13:31:28 UTC 
Created attachment 280998 [details] [review]
Add --version command-line option.
Comment 6 Michael Catanzaro 2014-07-17 13:41:54 UTC 
Sure

Attachment 280731 [details] pushed as ba9e534 - Remove white spaces.
Attachment 280997 [details] pushed as b967649 - Cosmetic move of code.
Attachment 280998 [details] pushed as 19ddf25 - Add --version command-line option.