After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733204 - Use constructed instead of constructor
Use constructed instead of constructor
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-15 14:22 UTC by Debarshi Ray
Modified: 2014-08-17 06:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screen-container: tab-label: Use constructed instead of constructor (4.13 KB, patch)
2014-07-15 14:28 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-07-15 14:22:37 UTC 
The constructed vfunc has been around for quite a while now, and that is what we should be using.
Comment 1 Debarshi Ray 2014-07-15 14:28:28 UTC 
Created attachment 280720 [details] [review]
screen-container: tab-label: Use constructed instead of constructor
Comment 2 Christian Persch 2014-08-16 17:15:08 UTC 
Comment on attachment 280720 [details] [review]
screen-container: tab-label: Use constructed instead of constructor

Looks fine. (The commit summary line looks a bit odd, usually a: b: text means category a subcategory b, not a&b.)
Comment 3 Debarshi Ray 2014-08-17 06:12:36 UTC 
Comment on attachment 280720 [details] [review]
screen-container: tab-label: Use constructed instead of constructor

Thanks for the review, Christian. I committed it after removing the categories from the commit message.