After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733176 - terminal: support for VTE 2.91 is required
terminal: support for VTE 2.91 is required
Status: RESOLVED DUPLICATE of bug 734275
Product: gedit-plugins
Classification: Other
Component: General
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-14 22:21 UTC by Dominique Leuenberger
Modified: 2019-03-23 20:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Support VTE 2.91 (27.02 KB, patch)
2014-07-14 22:26 UTC, Dominique Leuenberger 		none Details | Review
Minor logic error fixed (assigned variables inverted) (27.02 KB, patch)
2014-07-14 22:28 UTC, Dominique Leuenberger 		none Details | Review
terminal: Use VTE 2.91 (1.27 KB, patch)
2014-07-26 16:26 UTC, Dominique Leuenberger 		rejected Details | Review

Description Dominique Leuenberger 2014-07-14 22:21:15 UTC 
VTE was bumped to VTE 2.91.
Comment 1 Dominique Leuenberger 2014-07-14 22:26:56 UTC 
Created attachment 280680 [details] [review]
Support VTE 2.91

Adjust configure to:
- Detect VTE 2.90 or VTE 2.91 (stored in VTEVER)

Rename terminal.py to terminal.py.in
Have configure parse the file into terminal.py, replacing @VTEVER@ to the actually identified version of VTE found.

NOTE:
the python code could likely also be handled with try: exec statements, but the gi-dep scanner used by Mageia, openSUSE and likely others will certainly trip over finding two gi.requires('Vte', 'xxx') statements.
Comment 2 Dominique Leuenberger 2014-07-14 22:28:39 UTC 
Created attachment 280681 [details] [review]
Minor logic error fixed (assigned variables inverted)
Comment 3 Paolo Borelli 2014-07-15 07:28:40 UTC 
Review of attachment 280681 [details] [review]:

The patch looks good, but is it really worth it?

gedit-plugins 3.14 will come out with gnome 3.14 which includes vte 2.91.

I'd keep things simple and just bump the dep to 2.91 and disable the plugin otherwise
Comment 4 Dominique Leuenberger 2014-07-15 07:38:52 UTC 
(In reply to comment #3)
> gedit-plugins 3.14 will come out with gnome 3.14 which includes vte 2.91.
> 
> I'd keep things simple and just bump the dep to 2.91 and disable the plugin
> otherwise

Sounds fair...

i'll redo the patch with only changing the dep;
Comment 5 Dominique Leuenberger 2014-07-26 16:26:25 UTC 
Created attachment 281782 [details] [review]
terminal: Use VTE 2.91
Comment 6 Ignacio Casal Quinteiro (nacho) 2014-08-05 12:24:54 UTC 
Review of attachment 281782 [details] [review]:

sorry for the late response. Patch looks good to me.
Comment 7 Debarshi Ray 2014-08-05 12:25:36 UTC 
(In reply to comment #6)
> Review of attachment 281782 [details] [review]:
> 
> sorry for the late response. Patch looks good to me.

This patch is incomplete.
Comment 8 Debarshi Ray 2014-08-05 12:25:44 UTC 

*** This bug has been marked as a duplicate of bug 734275 ***