After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733146 - spawn helper does not use correctly the parameters
spawn helper does not use correctly the parameters
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: win32
2.41.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-win32 maintainers
gtk-win32 maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-14 07:18 UTC by Ignacio Casal Quinteiro (nacho)
Modified: 2014-07-14 12:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
spawn-win32 (7.21 KB, patch)
2014-07-14 07:18 UTC, Ignacio Casal Quinteiro (nacho) 		none Details | Review
spawn-win32 V2 (7.22 KB, patch)
2014-07-14 07:47 UTC, Ignacio Casal Quinteiro (nacho) 		committed Details | Review

Description Ignacio Casal Quinteiro (nacho) 2014-07-14 07:18:22 UTC 
Created attachment 280622 [details] [review]
spawn-win32

So it seems that we can't rely on the __argc and __argv global vars since we are getting unicode values and sometimes I guess windows gets confused and sets those global vars in the wrong way. Instead let's get the unicode ones and convert them to uft-8 and use the utf-8 ones. This seems to fix a crash when compiling gtk+, which uses the GSubprocess magic to compile the resources.
Comment 1 Ignacio Casal Quinteiro (nacho) 2014-07-14 07:47:17 UTC 
Created attachment 280628 [details] [review]
spawn-win32 V2

Minor fix
Comment 2 LRN 2014-07-14 08:01:28 UTC 
Review of attachment 280628 [details] [review]:

Code looks OK. If it passes tests, it should be good.