After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733122 - rgvolume/rtpdtmfmux: Avoid taking unnecessary ref to pad templates.
rgvolume/rtpdtmfmux: Avoid taking unnecessary ref to pad templates.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal minor
: 1.4.0
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-13 14:10 UTC by Sebastian Rasmussen
Modified: 2014-07-16 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch fixing leak 1/2. (995 bytes, patch)
2014-07-13 14:12 UTC, Sebastian Rasmussen 		committed Details | Review
Proposed patch fixing leak 2/2. (1.31 KB, patch)
2014-07-13 14:12 UTC, Sebastian Rasmussen 		committed Details | Review

Description Sebastian Rasmussen 2014-07-13 14:10:48 UTC 
gst_pad_get_pad_template() returns a reference that must be freed, but in these instances we might as well, just access the pad template directly I think.
Comment 1 Sebastian Rasmussen 2014-07-13 14:12:21 UTC 
Created attachment 280583 [details] [review]
Proposed patch fixing leak 1/2.
Comment 2 Sebastian Rasmussen 2014-07-13 14:12:35 UTC 
Created attachment 280584 [details] [review]
Proposed patch fixing leak 2/2.
Comment 3 Sebastian Dröge (slomo) 2014-07-16 14:46:19 UTC 
commit f45657f604a84a85186109b0c40fee4f807dbaab
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sun Jul 13 16:05:56 2014 +0200

    rgvolume: Avoid taking unnecessary refs
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=733122

commit ca22ad8da9f6d6523cb47146d7fd86b4b31581f1
Author: Sebastian Rasmussen <sebras@hotmail.com>
Date:   Sun Jul 13 16:04:23 2014 +0200

    rtpdtmfmux: Avoid taking an unnecessary ref
    
    Fixes https://bugzilla.gnome.org/show_bug.cgi?id=733122