After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733081 - [IMAPx] Job stuck after send when saving to IMAP server
[IMAPx] Job stuck after send when saving to IMAP server
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Mailer
3.12.x (obsolete)
Other Linux
: Normal major
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
: 733314 733410 733868 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-07-12 01:46 UTC by Adam Williamson
Modified: 2014-08-12 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdb 't a a bt' output for an affected Evo process (9.99 KB, text/plain)
2014-07-12 01:46 UTC, Adam Williamson
  Details
proposed eds patch (949 bytes, patch)
2014-07-14 10:29 UTC, Milan Crha
none Details | Review
proposed eds patch ][ (5.83 KB, patch)
2014-07-15 05:41 UTC, Milan Crha
none Details | Review
proposed eds patch ]I[ (5.84 KB, patch)
2014-07-15 14:06 UTC, Milan Crha
committed Details | Review

Description Adam Williamson 2014-07-12 01:46:25 UTC
Created attachment 280537 [details]
gdb 't a a bt' output for an affected Evo process

Filing a new report for the follow-on problem I discovered from https://bugzilla.gnome.org/show_bug.cgi?id=732366 . The scratch build of e-d-s with the fix for that bug - http://koji.fedoraproject.org/koji/taskinfo?taskID=7117386 - does indeed fix it, but seems to cause a new bug.

I have Evo configured such that when I send a mail, it stores the 'sent' copy not in the "on this computer" local account, but in the Sent folder of the IMAP server (that seems to be relevant here). With the e-d-s patched for #732366, quite often after I send an email, Evo gets stuck. I see the "sending message..." blue status bar appear and, shortly after, it briefly shows "Sending message (100% complete)". Usually at that point the window for the just-sent message would disappear and all would be well. However, when this bug hits, the status bar goes back to just "Sending message" and the window sticks like that, apparently forever. If I switch to the main Evo window I see other operations to the IMAP server piling up in the lower status area (folder refreshes), and I cannot open any mails that have not already been downloaded and cached - basically, any further communication with the server is blocked. The only escape is a killev.

I attached gdb to the running Evo while it was stuck in this state, much as requested in https://bugzilla.gnome.org/show_bug.cgi?id=732366 . I'll attach the 't a a bt' output; I don't know which frame to look at in this case. Please advise! Thanks.
Comment 1 Adam Williamson 2014-07-12 01:47:18 UTC
Note that the sent message *does* get successfully stored on the IMAP server.
Comment 2 Adam Williamson 2014-07-12 01:48:03 UTC
Gah, and I forgot to note - the message send operation does actually work. The mail does get sent out, and (as per c#1) does get stored in the IMAP server's Sent folder; it's after both those things happen that Evo gets stuck, apparently.
Comment 3 Milan Crha 2014-07-14 10:29:27 UTC
Created attachment 280635 [details] [review]
proposed eds patch

for evolution-data-server;

I think there left an incorrect IDLE state stored on the object, which then led to an "out of order" DONE command being issued on the connection, just in time of the message APPEND command, which confused the server enough to stop send of the APPEND command completion confirmation, for which the IMAPx is waiting.

It may eventually fix also Yaneti's issue.
Comment 4 Yanko Kaneti 2014-07-14 11:08:59 UTC
Running with attachment 280635 [details] [review] for the last 10-15 minutes and I've been able to reliably send myself 2-3 messages that get appended to a Sent folder on the same server.

I'll have to run this longer to see if it gets stuck somewhere.
Comment 5 Milan Crha 2014-07-15 05:41:25 UTC
Created attachment 280686 [details] [review]
proposed eds patch ][

for evolution-data-server;

Hrm, I noticed some critical warnings on the console caused by the previous patch. I thought of this and I believe the main issue was the way I tried to solve bug #730788, which led to bug #732366 and finally here. I simply chose an incorrect approach. The right way to fix all of these issues should be this new patch. I was using it for some time and it seems correct.

Please revert the previous patch from here and apply this one (it's cleanly applicable on git master) and let me know. Thanks in advance.
Comment 6 Milan Crha 2014-07-15 14:06:24 UTC
Created attachment 280716 [details] [review]
proposed eds patch ]I[

for evolution-data-server;

A mix of the previous patches. I'm still not able to reproduce this reliably, otherwise I would provide more consistent fix. I'm sorry for that.
Comment 7 b81 2014-07-15 14:23:43 UTC
It fixes the issue in my case. The bug is reproducable here, the message window hangs everytime I send a message and evolution has to be killed.
Comment 8 Milan Crha 2014-07-16 15:04:55 UTC
Thanks for the testing. I've got a confirmation from Yanko too (on IRC), thus I'm moving the patch to sources. I will also create a ...-2 update for Fedora, for those interested.

Created commit e60f804 in eds master (3.13.4+) [1]
Created commit b8456c7 in eds evolution-data-server-3-12 (3.12.5+)

[1] https://git.gnome.org/browse/evolution-data-server/commit/?id=e60f804
Comment 9 Adam Williamson 2014-07-16 16:55:07 UTC
sorry I never got around to testing the patches, been a bit crazy here the last few days! I'm installing the new F21 package now, will let you know if I see further problems. thanks!
Comment 10 Milan Crha 2014-07-17 17:18:19 UTC
That's OK. Yaneti opened bug 733314 where we do some follow-up debugging, because the issue is still not fixed. Once we debug it there, I will mark it as a duplicate of this bug report and will update this bug report with the follow-up change. It might be tomorrow, with a bit of luck (we had 3 iterations already today) :)
Comment 11 Adam Williamson 2014-07-17 19:33:41 UTC
well, I installed the -2 build for F21 and put my Evo back to the problematic settings (1 minute checks, IDLE enabled) and haven't seen it get stuck in either way since, but maybe I've just been lucky.
Comment 12 Milan Crha 2014-07-18 05:26:07 UTC
Right, you might be just lucky, the same as I am. I found a flaw in the code while investigating the issue with Yaneti, which we are fixing meanwhile.
Comment 13 Milan Crha 2014-07-18 09:49:26 UTC
*** Bug 733314 has been marked as a duplicate of this bug. ***
Comment 14 Milan Crha 2014-07-18 09:55:12 UTC
The follow up change landed as:

Created commit 738e1f0 in eds master (3.13.4+) [1]
Created commit 80c281d in eds evolution-data-server-3-12 (3.12.5+)

[1] https://git.gnome.org/browse/evolution-data-server/commit/?id=738e1f0
Comment 15 Joachim Breitner 2014-07-19 18:43:27 UTC
*** Bug 733410 has been marked as a duplicate of this bug. ***
Comment 16 Joachim Breitner 2014-07-21 07:44:39 UTC
In order to not only complain and report new bugs: :-)

It seems that these patches have fixed that particular problem for me.
Comment 17 Dominik Grafenhofer 2014-08-11 07:19:30 UTC
I confirm, that the patchs seems to have fixed the problem for me.
Comment 18 Jürg Billeter 2014-08-12 16:49:28 UTC
*** Bug 733868 has been marked as a duplicate of this bug. ***