After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733062 - Evdev: set button state in input devices
Evdev: set button state in input devices
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-11 13:35 UTC by Carlos Garnacho
Modified: 2014-07-14 17:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
evdev: Set button modifier state to input devices. (1.23 KB, patch)
2014-07-11 13:36 UTC, Carlos Garnacho 		committed Details | Review

Description Carlos Garnacho 2014-07-11 13:35:04 UTC 
(filing to general, there doesn't seem to be an evdev component :)

The evdev backend seems to be currently just setting keyboard modifier state in both pointer/keyboard devices, this makes clutter_input_device_get_modifier_state() return all 0s for CLUTTER_BUTTON?_MASK. I'm attaching a small patch to fix that.
Comment 1 Carlos Garnacho 2014-07-11 13:36:08 UTC 
Created attachment 280505 [details] [review]
evdev: Set button modifier state to input devices.

Input devices must get the proper button state, in addition to keyboard
modifiers.
Comment 2 Emmanuele Bassi (:ebassi) 2014-07-11 13:58:16 UTC 
Review of attachment 280505 [details] [review]:

looks reasonable to me.
Comment 3 Carlos Garnacho 2014-07-14 17:20:19 UTC 
Attachment 280505 [details] pushed as f6fd029 - evdev: Set button modifier state to input devices.