After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733061 - Make bookmarking more robust against failure
Make bookmarking more robust against failure
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-11 13:16 UTC by Debarshi Ray
Modified: 2014-07-11 17:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
preview: Cache the 'bookmark-page' action (1.88 KB, patch)
2014-07-11 13:27 UTC, Debarshi Ray
committed Details | Review
preview, places: Disable bookmarking if metadata is unsupported (4.49 KB, patch)
2014-07-11 13:30 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2014-07-11 13:16:26 UTC
Our bookmarking feature depends on GVfs. I agree that the absence of GVfs can be considered as a broken system, but this is a common scenario if someone wants to quickly build and try the application against gtk+ and glib master. Lets try to accommodate this without throwing exceptions or getting into elaborate fallback code paths.
Comment 1 Debarshi Ray 2014-07-11 13:27:56 UTC
Created attachment 280503 [details] [review]
preview: Cache the 'bookmark-page' action
Comment 2 Debarshi Ray 2014-07-11 13:30:26 UTC
Created attachment 280504 [details] [review]
preview, places: Disable bookmarking if metadata is unsupported
Comment 3 Cosimo Cecchi 2014-07-11 15:55:10 UTC
Review of attachment 280503 [details] [review]:

OK
Comment 4 Cosimo Cecchi 2014-07-11 15:56:28 UTC
Review of attachment 280504 [details] [review]:

Looks good