After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733059 - Use the new gear menu icon
Use the new gear menu icon
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-11 12:31 UTC by Matthias Clasen
Modified: 2014-07-14 22:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Use the new gear menu icon (1.17 KB, patch)
2014-07-11 12:31 UTC, Matthias Clasen
none Details | Review

Description Matthias Clasen 2014-07-11 12:31:32 UTC
Instead of misusing emblem-system-symbolic, there is now a
dedicated icon for this purpose. Just setting the right
direction on the menu button makes GTK+ use the correct icon.
Comment 1 Matthias Clasen 2014-07-11 12:31:34 UTC
Created attachment 280502 [details] [review]
Use the new gear menu icon
Comment 2 Pierre-Yves Luyten 2014-07-11 12:48:26 UTC
thanks I will push this soon , just have to fix or create a new vm before because open-menu-symbolic is a recent commit
Comment 3 Matthias Clasen 2014-07-11 12:48:51 UTC
to avoid confusion between the similar looking 'view as list' button and the
'gear menu' button that is put in the same place when viewing an individual
note, I would recommend to replace the current 'view as list/view as grid'
button by a linked toggle button group, as seen in nautilus.
Comment 4 Pierre-Yves Luyten 2014-07-14 22:46:07 UTC
The original patch is pushed, I just removed a warning from a useless variable declaration
0b1f9a94d4eeafc17e34ff35633f3fd2cb6ea817


Given this open-menu icon is not shown on the same "state" (GtkStack) than grid/list icons, I hope either this will not produce confusion or, default icons will be adapted. I wondered about consistency, too, however Documents uses a single icon for the same use case.