After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733053 - Properly detect X for mingw
Properly detect X for mingw
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: common
1.3.3
Other Windows
: Normal normal
: NONE
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-11 11:17 UTC by Alexey Pavlov
Modified: 2014-11-24 13:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix detection X for mingw (479 bytes, patch)
2014-07-11 11:17 UTC, Alexey Pavlov 		needs-work Details | Review

Description Alexey Pavlov 2014-07-11 11:17:01 UTC 
Created attachment 280496 [details] [review]
fix detection X for mingw

Need check also X11/XKBlib.h for mingw
Comment 1 Sebastian Dröge (slomo) 2014-07-11 11:33:22 UTC 
Why exactly is that needed? We don't really use XKBlib.h anywhere
Comment 2 Alexey Pavlov 2014-07-11 11:36:02 UTC 
Because we sometimes have Xlib.h for mingw and get false result finding X.
Comment 3 Sebastian Dröge (slomo) 2014-07-11 11:38:31 UTC 
That sounds like a bug in mingw though.

Can you provide another patch that checks for both headers at once instead of separately?
Comment 4 Tim-Philipp Müller 2014-11-24 13:12:41 UTC 
This should be fixed in master, where we just use pkg-config:

commit f7d6087d53944a56906ad5240bf9abe2f0146c4f
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Sun Aug 10 17:30:18 2014 +0100

    configure: use pkg-config to detect x11 and xv libs
    
    AC_PATH_XTRA macro unnecessarily pulls in libSM and libICE.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=731047


(gst-plugins-bad still seems to use AG_GST_CHECK_X for some non-essential stuff like the not-ported nas audio plugin).

Please re-open if you still have problems with git master, thanks.