After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733030 - deploy: Clean up leftover state before creating new directories
deploy: Clean up leftover state before creating new directories
Status: RESOLVED FIXED
Product: ostree
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: OSTree maintainer(s)
OSTree maintainer(s)
Depends on:
Blocks: 732526
 
 
Reported: 2014-07-10 19:35 UTC by Colin Walters
Modified: 2014-09-13 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
deploy: Clean up leftover state before creating new directories (1.98 KB, patch)
2014-07-10 19:35 UTC, Colin Walters 		committed Details | Review

Description Colin Walters 2014-07-10 19:35:00 UTC 
This fixes a regression introduced with https://git.gnome.org/browse/ostree/commit/?id=7baa600e237b326899de2899a9bc54a6b863943c

The original code in "ostree admin upgrade" had a comment:

 /* Here we perform cleanup of any leftover data from previous
  * partial failures. This avoids having to call gs_shutil_rm_rf()
  * at random points throughout the process. */

But since I deleted that initial cleanup call, we *do* need to do the
cleanup during the process run.  It turns out there are only a few
places this is necessary.
Comment 1 Colin Walters 2014-07-10 19:35:02 UTC 
Created attachment 280447 [details] [review]
deploy: Clean up leftover state before creating new directories
Comment 2 Colin Walters 2014-09-13 14:43:44 UTC 
No review, but I believe this is correct.
Comment 3 Colin Walters 2014-09-13 14:43:58 UTC 
Attachment 280447 [details] pushed as 12e3ed8 - deploy: Clean up leftover state before creating new directories