Created attachment 280433 [details] [review]
ephy-certificate-dialog: reword bad identity error message

This wording should be a bit less confusing.

Created attachment 280434 [details] [review]
ephy-certificate-dialog: remove old code

We do not use the action area now that we have header bars

Created attachment 280435 [details] [review]
ephy-certificate-dialog: fix position of lock icon

If the cert is untrusted then the lock icon displays parallel to the
first row of text; it needs to be centered between them.

Created attachment 280436 [details] [review]
ephy-certificate-dialog: display window title

The blank header bar feels quite odd.

Created attachment 280437 [details] [review]
ephy-certificate-dialog: use better default height

Reduce the amount of blank space on this dialog when technical details
are not being displayed. It's just too much. This height is still large
enough that users who want to browse through all the details probably
won't want to resize the window.

Review of attachment 280433 [details] [review]:

Ok

Review of attachment 280434 [details] [review]:

Ok

Review of attachment 280435 [details] [review]:

Looks indeed better, thanks!

Review of attachment 280436 [details] [review]:

I think this is a bug in your GTK+ version, because gtk_window_set_title calls gtk_header_bar_set_title() when it has a header bar as title box.

Review of attachment 280437 [details] [review]:

Ok

Attachment 280433 [details] pushed as 81960c6 - ephy-certificate-dialog: reword bad identity error message
Attachment 280434 [details] pushed as 5f50e89 - ephy-certificate-dialog: remove old code
Attachment 280435 [details] pushed as d6988b2 - ephy-certificate-dialog: fix position of lock icon
Attachment 280437 [details] pushed as deaa6ab - ephy-certificate-dialog: use better default height

Looks like the header bar title got broken sometime between 3.12.0 and current master...

Bug #733099. Let's just not push that patch.