After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 733020 - Port Undo/Redo stacks to Gee.ArrayList
Port Undo/Redo stacks to Gee.ArrayList
Status: RESOLVED FIXED
Product: gnome-sudoku
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-sudoku-maint
gnome-sudoku-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-10 17:21 UTC by Parin Porecha
Modified: 2014-07-10 21:18 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Port Undo/Redo Stacks to Gee.ArrayList from GLib.SList (3.73 KB, patch)
2014-07-10 17:22 UTC, Parin Porecha 		reviewed Details | Review
Port Undo/Redo Stacks to Gee.ArrayList from GLib.SList (3.75 KB, patch)
2014-07-10 20:04 UTC, Parin Porecha 		committed Details | Review

Description Parin Porecha 2014-07-10 17:21:31 UTC 
Prepending Undo items to the stacks and removing them leaves dangling pointers.
Due to this, implementing Sudoku Tracker causes Sudoku to crash while freeing UndoItems.
Comment 1 Parin Porecha 2014-07-10 17:22:44 UTC 
Created attachment 280430 [details] [review]
Port Undo/Redo Stacks to Gee.ArrayList from GLib.SList
Comment 2 Michael Catanzaro 2014-07-10 19:10:08 UTC 
Review of attachment 280430 [details] [review]:

Yay!

::: lib/sudoku-game.vala
@@ +118,2 @@
         }
         /* Undoing reset action */

This isn't possible anymore, so this code can be removed, right?
Comment 3 Parin Porecha 2014-07-10 20:04:16 UTC 
Created attachment 280449 [details] [review]
Port Undo/Redo Stacks to Gee.ArrayList from GLib.SList

ah, sorry I missed it !
Comment 4 Michael Catanzaro 2014-07-10 21:04:22 UTC 
Review of attachment 280449 [details] [review]:

great
Comment 5 Parin Porecha 2014-07-10 21:17:58 UTC 
Comment on attachment 280449 [details] [review]
Port Undo/Redo Stacks to Gee.ArrayList from GLib.SList

Pushed as 06dcebe