After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732984 - g_object_ref(NULL) in g_dbus_object_manager_client_finalize
g_object_ref(NULL) in g_dbus_object_manager_client_finalize
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gio
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-07-10 09:57 UTC by Patrick Ohly
Modified: 2014-07-14 12:38 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
adds missing NULL check (1.17 KB, patch)
2014-07-10 09:58 UTC, Patrick Ohly 		committed Details | Review

Description Patrick Ohly 2014-07-10 09:57:30 UTC 
See patch for details.
Comment 1 Patrick Ohly 2014-07-10 09:58:15 UTC 
Created attachment 280358 [details] [review]
adds missing NULL check
Comment 2 Emmanuele Bassi (:ebassi) 2014-07-10 10:28:05 UTC 
Review of attachment 280358 [details] [review]:

::: gio/gdbusobjectmanagerclient.c
@@ +205,3 @@
       g_object_unref (manager->priv->control_proxy);
     }
+  if (manager->priv->connection != NULL)

the usual pattern, these days, is to use g_clear_object(), which is NULL-safe.