After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732964 - crash after deleting opened photo
crash after deleting opened photo
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: general
0.18.x
Other Linux
: Normal normal
: 0.20
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-09 20:13 UTC by Mike Gorse
Modified: 2014-07-24 21:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch. (1.01 KB, patch)
2014-07-09 20:16 UTC, Mike Gorse 		rejected Details | Review
Proposed patch to remove deleted photos from the collection. (1.48 KB, patch)
2014-07-22 20:41 UTC, Mike Gorse 		none Details | Review

Description Mike Gorse 2014-07-09 20:13:26 UTC 
reproduce:
1. Select a photo.
2. Press enter to switch the view to the selected photo.
3. Press shift-delete, then right arrow, then enter, to delete without moving to trash.
4. Press left arrow.
5. Repeat step 3.

The result is a crash caused by an assert failure when shotwell tries to delete the photo a second time.
Comment 1 Mike Gorse 2014-07-09 20:16:35 UTC 
Created attachment 280298 [details] [review]
Proposed patch.

I'm not 100% sure that this is the right thing to do, but it fixes the crash.
Comment 2 Jim Nelson 2014-07-17 22:49:01 UTC 
Review of attachment 280298 [details] [review]:

This prevents the crash but doesn't really address the problem, which is that the removed photo has remained in the photo viewer's collection.  That's the real fix to this problem.  This patch sends the user back to the library when deleting a photo, which is not the experience we want.
Comment 3 Mike Gorse 2014-07-22 20:41:03 UTC 
Created attachment 281437 [details] [review]
Proposed patch to remove deleted photos from the collection.

Thanks. Attaching a new patch.
Comment 4 Jim Nelson 2014-07-24 21:02:54 UTC 
Much better.  Thanks!

Pushed to master, commit 3c8ac3