After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732894 - icontheme: Use correct URI for icons in resource paths
icontheme: Use correct URI for icons in resource paths
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-07-08 12:17 UTC by Stefano Facchini
Modified: 2014-07-09 15:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
icontheme: Use correct URI for icons in resource paths (2.12 KB, patch)
2014-07-08 12:17 UTC, Stefano Facchini
committed Details | Review

Description Stefano Facchini 2014-07-08 12:17:38 UTC
It seems that resource icons are currently looked for at URIs like
file:///org/gnome/appname/icons/, which obviously doesn't work.
Comment 1 Stefano Facchini 2014-07-08 12:17:40 UTC
Created attachment 280141 [details] [review]
icontheme: Use correct URI for icons in resource paths
Comment 2 Matthias Clasen 2014-07-09 03:18:59 UTC
not true - gtk includes several resource icons that are loaded just fine.
Comment 3 Stefano Facchini 2014-07-09 07:58:29 UTC
(In reply to comment #2)
> not true - gtk includes several resource icons that are loaded just fine.

Yes, because they are all non-symbolic and apparently follow a different codepath. I should have stated in the bug subject that there's a problem only with symbolic icons. As a testcase, you can try the resource-icons branch of baobab. (If you do that, don't forget to first "jhbuild uninstall baobab" to remove icon files from the jhbuild tree).
Comment 4 Stefano Facchini 2014-07-09 07:59:34 UTC
> (If you do that, don't forget to first "jhbuild uninstall baobab" to
> remove icon files from the jhbuild tree).

And maybe from /usr/share/icons/, too.
Comment 5 Matthias Clasen 2014-07-09 13:35:07 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > not true - gtk includes several resource icons that are loaded just fine.
> 
> Yes, because they are all non-symbolic and apparently follow a different
> codepath. I should have stated in the bug subject that there's a problem only
> with symbolic icons. As a testcase, you can try the resource-icons branch of
> baobab. (If you do that, don't forget to first "jhbuild uninstall baobab" to
> remove icon files from the jhbuild tree).

The places that your patch touches are not specific to symbolic icons. Anyway, thanks for the hints, I'll try to come up with a testcase.
Comment 6 Matthias Clasen 2014-07-09 15:21:19 UTC
Attachment 280141 [details] pushed as cd71a23 - icontheme: Use correct URI for icons in resource paths