Created attachment 280102 [details] [review]
fix: use tabs instead of spaces

small fix before inserting the mb-track-id

Created attachment 280103 [details] [review]
core: add "mb-track-id"

MusicBrainz track ID

Review of attachment 280102 [details] [review]:

Sure.

Review of attachment 280103 [details] [review]:

Add a link to the definition of that identifier in the commit message.

::: src/data/grl-media-audio.c
@@ +473,3 @@
+grl_media_audio_get_mb_track_id (GrlMediaAudio *audio)
+{
+  return grl_data_get_string (GRL_DATA (audio), GRL_METADATA_KEY_MB_TRACK_ID);

Add a guard (g_return_val_if_fail...)

::: src/grl-metadata-key.h
@@ +100,3 @@
 #define GRL_METADATA_KEY_TITLE_FROM_FILENAME  51
 #define GRL_METADATA_KEY_MB_ALBUM_ID          52
+#define GRL_METADATA_KEY_MB_TRACK_ID          53

Pretty sure that you're missing a doc entry for this (needs a URL link as well)

Review of attachment 280102 [details] [review]:

up

Created attachment 283711 [details] [review]
core: add GRL_METADATA_KEY_MB_TRACK_ID

MusicBrainz track identifier.

Created attachment 283712 [details] [review]
core: add GRL_METADATA_KEY_MB_ARTIST_ID

MusicBrainz artist identifier.

(In reply to comment #4)
> Review of attachment 280103 [details] [review]:
> 
> Add a link to the definition of that identifier in the commit message.

Forgot this one, I'll edit the commit message.
mb-track-id is related to recording: https://wiki.musicbrainz.org/Recording
and mb-artist-id https://wiki.musicbrainz.org/artist

> ::: src/data/grl-media-audio.c
> @@ +473,3 @@
> +grl_media_audio_get_mb_track_id (GrlMediaAudio *audio)
> +{
> +  return grl_data_get_string (GRL_DATA (audio), GRL_METADATA_KEY_MB_TRACK_ID);
> 
> Add a guard (g_return_val_if_fail...)

Fixed.

> 
> ::: src/grl-metadata-key.h
> @@ +100,3 @@
>  #define GRL_METADATA_KEY_TITLE_FROM_FILENAME  51
>  #define GRL_METADATA_KEY_MB_ALBUM_ID          52
> +#define GRL_METADATA_KEY_MB_TRACK_ID          53
> 
> Pretty sure that you're missing a doc entry for this (needs a URL link as well)

I didn't find it. I'm using other commit as referece to add those keys  ec35e862057

Review of attachment 283711 [details] [review]:

Looks good.

Review of attachment 283712 [details] [review]:

Looks good.

Attachment 283711 [details] pushed as 9cee9ff - core: add GRL_METADATA_KEY_MB_TRACK_ID
Attachment 283712 [details] pushed as 2fa07bd - core: add GRL_METADATA_KEY_MB_ARTIST_ID