After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732876 - Crash when searching in history dialog
Crash when searching in history dialog
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: History
git master
Other Mac OS
: Normal critical
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-08 03:45 UTC by Michael Catanzaro
Modified: 2014-07-11 18:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
backtrace (30.17 KB, text/plain)
2014-07-08 03:45 UTC, Michael Catanzaro 		  Details
Proposed patch (1.00 KB, patch)
2014-07-08 08:39 UTC, Robert Roth 		committed Details | Review

Description Michael Catanzaro 2014-07-08 03:45:11 UTC 
Created attachment 280101 [details]
backtrace

Open the history dialog and search for any reasonably long search term, such as aaaaaaaaaaaaaa. Epiphany crashes reliably.
Comment 1 Michael Catanzaro 2014-07-08 03:47:57 UTC 
Robert, can you take a look at this please?
Comment 2 Robert Roth 2014-07-08 08:34:27 UTC 
Actually that seems to happen regardless of the search term length, in case there are no results. Fix is on the way.
Comment 3 Robert Roth 2014-07-08 08:39:28 UTC 
Created attachment 280122 [details] [review]
Proposed patch

Fixed the crash caused by no results in a history search.
Comment 4 Bastien Nocera 2014-07-10 13:17:02 UTC 
Review of attachment 280122 [details] [review]:

Looks good.
Comment 5 Carlos Garcia Campos 2014-07-10 14:39:23 UTC 
Review of attachment 280122 [details] [review]:

Thanks!
Comment 6 Robert Roth 2014-07-11 18:35:18 UTC 
Review of attachment 280122 [details] [review]:

Committed with revision 6d8e4950a379f31e5b0ba78f9d2990f62bbfc54f.
Comment 7 Robert Roth 2014-07-11 18:35:32 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.