After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732793 - Void function should not return a value
Void function should not return a value
Status: RESOLVED FIXED
Product: gnome-software
Classification: Applications
Component: General
3.13.x
Other FreeBSD
: Normal normal
: ---
Assigned To: GNOME Software maintainer(s)
GNOME Software maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-06 04:22 UTC by Ting-Wei Lan
Modified: 2014-07-06 12:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix "void function should not return a value" error for clang (794 bytes, patch)
2014-07-06 04:22 UTC, Ting-Wei Lan 		accepted-commit_now Details | Review

Description Ting-Wei Lan 2014-07-06 04:22:24 UTC 
Created attachment 279975 [details] [review]
Fix "void function should not return a value" error for clang

I get this error when compiling gnome-software:

gs-shell.c:468:2: error: void function 'gs_shell_setup' should not return a value [-Wreturn-type]

gs_shell_setup uses g_return_val_if_fail in src/gs-shell.c, and it should be changed to g_return_if_fail.
Comment 1 Kalev Lember 2014-07-06 11:05:04 UTC 
Review of attachment 279975 [details] [review]:

Thanks for catching this! The patch looks good to me.