After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732706 - Allow setting up quad-buffer stereo output
Allow setting up quad-buffer stereo output
Status: RESOLVED FIXED
Product: clutter
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: clutter-maint
clutter-maint
Depends on:
Blocks:
 
 
Reported: 2014-07-03 18:50 UTC by Owen Taylor
Modified: 2015-03-07 12:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Allow setting up quad-buffer stereo output (9.33 KB, patch)
2014-07-03 18:50 UTC, Owen Taylor
committed Details | Review

Description Owen Taylor 2014-07-03 18:50:22 UTC
This depends on the cogl changes in the wip/quadbuffer-stereo branch.
Comment 1 Owen Taylor 2014-07-03 18:50:24 UTC
Created attachment 279863 [details] [review]
Allow setting up quad-buffer stereo output

Add clutter_x11_set_use_stereo_stage() that can be called
before clutter_init() so that the CoglDisplay we create and all
stages created from that CoglDisplay will be created with a
stereo fbconfig.

This is done in clutter-x11 because of the similarity to the
existing clutter_x11_set_use_argb_visual(), and because it's
not clear without other examples whether the need to have
stereo enabled from before clutter_init() is universal or
somethign specific to GLX.
Comment 2 Emmanuele Bassi (:ebassi) 2014-08-13 13:00:29 UTC
Review of attachment 279863 [details] [review]:

in general, it looks good to me.

::: clutter/x11/clutter-backend-x11.c
@@ +708,3 @@
+   * could just return that display, then it would be more efficient
+   * not to use cogl_renderer_check_onscreen_template(). However, the
+   * backend API requires that we return an CoglDisplay that has not

the backend API does not require much: it's just the way it was written to provide enough overridable steps for every backend.

it's all private anyway, so if you want to change its semantics, it's perfectly fine by me; you just need to ensure that the other backends can use the same semantics.
Comment 3 André Klapper 2015-02-22 21:16:43 UTC
Patch has been in "accepted-commit_now" status for >200 days now.

Owen, ebassi: Anybody willing to push?
Comment 4 Emmanuele Bassi (:ebassi) 2015-02-22 21:32:18 UTC
(In reply to André Klapper from comment #3)
> Patch has been in "accepted-commit_now" status for >200 days now.
> 
> Owen, ebassi: Anybody willing to push?

I don't think the needed API landed in Cogl, or that Cogl had a release with the API. I'm also not really enthused by the prospect of bumping the Cogl dependency at the end of the cycle.

I'll defer to Owen for this one.
Comment 5 Owen Taylor 2015-02-23 21:44:39 UTC
The Cogl API changes were been sitting in the tree without a release since July.
Robert Bragg has now done a 1.20 release of Cogl with the new API.

Attachment 279863 [details] pushed as c32dc34 - Allow setting up quad-buffer stereo output