After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732694 - glimagesink: handle drain query
glimagesink: handle drain query
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other All
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Reported: 2014-07-03 15:39 UTC by Julien Isorce
Modified: 2014-11-12 12:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

glimagesink: release stored buffer on drain query (1.05 KB, patch)
2014-07-03 15:39 UTC, Julien Isorce
needs-work Details | Review

Description Julien Isorce 2014-07-03 15:39:10 UTC
Created attachment 279849 [details] [review]
glimagesink: release stored buffer on drain query

gst-launch-1.0 filesrc location=speedway_raw.h264 ! h264parse ! omxh264dec  ! glimagesink

With attached patch you get

The stream file:

(I had to set enable-last-sample=0 because I do not have the patche for GstBaseSink about the drain query here. So no need it on current master)
Comment 1 Julien Isorce 2014-10-30 18:28:17 UTC
I think we need this patch but not sure it still applies with current upstream. For the story I remember having pushed this in eglglessink but since it has been removed we need this in glimagesink.
Comment 2 Matthew Waters (ystreet00) 2014-11-02 00:54:59 UTC
Review of attachment 279849 [details] [review]:

You'll also need to clear the buffer in glimage_sink->upload using gst_gl_upload_release_buffer ()
Comment 3 Julien Isorce 2014-11-05 08:33:04 UTC
Ah thx, I will also try to make a unit test.
Comment 4 Julien Isorce 2014-11-12 00:15:07 UTC
commit 004a414b4a938c0523bed9c5a9c81675c6fdf665
Author: Julien Isorce <>
Date:   Tue Nov 11 23:49:59 2014 +0000

    glimagesink: release stored buffers on drain query

commit 7d0de0577ad11694adc137d89f63bc68da83e1d3
Author: Julien Isorce <>
Date:   Tue Nov 11 23:43:42 2014 +0000

    gl: do not raise a critical msg if the backend does not handle window events
    Fix "assertion 'window_class->handle_events != NULL' failed"
    if not using a X11 window.
Comment 5 Julien Isorce 2014-11-12 00:15:31 UTC
commit 7bb1ea7094933a73845aeeef0694270320f2dced
Author: Julien Isorce <>
Date:   Tue Nov 11 23:54:44 2014 +0000

    gl: add unit test that checks for glimagesink drain query handling
Comment 6 Matthew Waters (ystreet00) 2014-11-12 00:46:08 UTC
commit 5c48440c9a8e1dbba3f7c11f4ab4408973f64684
Author: Matthew Waters <>
Date:   Wed Nov 12 11:44:07 2014 +1100

    glimagesink: don't set the upload to NULL on the drain query
Comment 7 Julien Isorce 2014-11-12 12:17:56 UTC
commit 92796446a23bae05cf3fd70cfe161f04e0dac980
Author: Julien Isorce <>
Date:   Wed Nov 12 09:41:53 2014 +0000

    tests: add CFLAGS and LADD for glimagesink unit test