After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732685 - Other bases not updated when changing the main base in programming mode
Other bases not updated when changing the main base in programming mode
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
3.18.x
Other Linux
: Normal normal
: ---
Assigned To: gcalctool maintainers
gcalctool maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-03 13:10 UTC by Antonio Ospite
Modified: 2016-10-11 08:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Update the bit panel and the base label when the numbering base is changed (1.12 KB, patch)
2016-07-09 14:56 UTC, Antonio Ospite 		committed Details | Review

Description Antonio Ospite 2014-07-03 13:10:12 UTC 
Hi,

when changing the base in Programming mode, the "preview text" about the value expressed in the other bases is not updated (the one on the right, below the main input area).

Here is how to reproduce the problem with 3.12.2:

1. Enter programming mode
2. Choose Decimal base
3. Insert a value, e.g. 15; now the "preview text" shows: 17₈ = F₁₆ (the bases are shown as subscripts).
4. Change the base to Hexadecimal; the main input area is updated but the preview text is not, it shows the same text as before instead of: 17₈ = 15₁₀

I think the preview should be always like that:
when the main unit is Decimal it should preview (Octal = Hexadecimal)
when the main unit is Hexadecimal it should preview (Octal = Decimal)
when the main unit is Octal it should preview (Decimal = Hexadecimal)

but right now it is not updated automatically when changing base.

Thanks,
   Antonio
Comment 1 Antonio Ospite 2014-09-30 11:49:49 UTC 
Still present in 3.14
Comment 2 Antonio Ospite 2015-09-23 09:55:26 UTC 
Still present in 3.18
Comment 3 Alberto Ruiz 2015-10-20 11:48:23 UTC 
Noted, I need to find some time to fix this though.
Comment 4 Antonio Ospite 2016-07-09 14:56:14 UTC 
Created attachment 331129 [details] [review]
Update the bit panel and the base label when the numbering base is changed

Hi,

I am attaching a patch to fix this, at the end of the day it was enough to call update_bit_panel() from base_changed_cb().

Thanks,
   Antonio
Comment 5 Robert Roth 2016-10-11 08:05:38 UTC 
Attachment 331129 [details] pushed as 7a8ac5f - Update the bit panel and the base label when the numbering base is changed