After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732676 - Pass the content type to RefreshDB
Pass the content type to RefreshDB
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-03 11:45 UTC by Saurav Agarwalla
Modified: 2014-07-07 11:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
src: Pass the content type to RefreshDB (1.91 KB, patch)
2014-07-03 11:49 UTC, Saurav Agarwalla 		needs-work Details | Review
application: Pass "photos" as the index type to RefreshDB (1.85 KB, patch)
2014-07-07 11:57 UTC, Debarshi Ray 		committed Details | Review

Description Saurav Agarwalla 2014-07-03 11:45:52 UTC 
Bug 728878 added content types as argument for the RefreshDB method call. We need to modify the relevant call in GNOME Photos, too.
Comment 1 Saurav Agarwalla 2014-07-03 11:49:09 UTC 
Created attachment 279834 [details] [review]
src: Pass the content type to RefreshDB
Comment 2 Debarshi Ray 2014-07-07 11:56:50 UTC 
Review of attachment 279834 [details] [review]:

Thanks for the patch, Saurav.

::: src/photos-application.c
@@ +439,3 @@
   cancellable = g_cancellable_new ();
   g_object_set_data_full (G_OBJECT (miner), "cancellable", cancellable, g_object_unref);
+  gom_miner_call_refresh_db (miner, &index_types[0], cancellable, photos_application_refresh_db, g_object_ref (self));

You could have just used 'index_types'. The array 'index_types' will automatically decay into a pointer when it is passed to the function.

::: src/photos-gom-miner.xml
@@ +25,3 @@
 <node name="/" xmlns:doc="http://www.freedesktop.org/dbus/1.0/doc.dtd">
   <interface name="org.gnome.OnlineMiners.Miner">
+    <method name='RefreshDB'>

Changing the quotes from double to single was not necessary.
Comment 3 Debarshi Ray 2014-07-07 11:57:41 UTC 
Created attachment 280048 [details] [review]
application: Pass "photos" as the index type to RefreshDB

Corrected and pushed.