Created attachment 279803 [details] [review]
main-icon-view: Set CellRendererPixbuf:follow-state to TRUE

So that prelight works.

Allan, Jimmac, Cosimoc said I should consult you about this. He said he remembered we didn't want this in Documents but he didn't remember the reason.

(In reply to comment #2)
> Allan, Jimmac, Cosimoc said I should consult you about this. He said he
> remembered we didn't want this in Documents but he didn't remember the reason.

I know that Jon was concerned about overuse of hover effects, since it can be distracting when mousing from area of the screen to another. That said, I think there were subsequent discussions where we agreed that prelighting of the icons wouldn't be too bad in this regard. My personal view is that a prelight would help to communicate the interactivity of the icons.

One way to overcome the potentially distracting effect of the prelight would be to use a timeout, or detect if the pointer has slowed/come to a stop over the icon.

(In reply to comment #3)
> (In reply to comment #2)
> > Allan, Jimmac, Cosimoc said I should consult you about this. He said he
> > remembered we didn't want this in Documents but he didn't remember the reason.
> 
> I know that Jon was concerned about overuse of hover effects, since it can be
> distracting when mousing from area of the screen to another. That said, I think
> there were subsequent discussions where we agreed that prelighting of the icons
> wouldn't be too bad in this regard. My personal view is that a prelight would
> help to communicate the interactivity of the icons.

Good, then I'd suggest we do this in libgd.

> One way to overcome the potentially distracting effect of the prelight would be
> to use a timeout, or detect if the pointer has slowed/come to a stop over the
> icon.

That would be something to implement in gtk+ I guess. I filed bug#732675 for that.

Review of attachment 279803 [details] [review]:

As long as Allan/Jakub are happy with this, looks good to me.