After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732647 - When recipients ellipsized in inline composer, provide tooltip
When recipients ellipsized in inline composer, provide tooltip
Status: RESOLVED FIXED
Product: geary
Classification: Other
Component: composer
master
Other Linux
: Normal normal
: 0.8.0
Assigned To: Geary Maintainers
Geary Maintainers
review
Depends on:
Blocks:
 
 
Reported: 2014-07-02 18:51 UTC by Jim Nelson
Modified: 2014-07-08 21:51 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add tooltip to compact composer header (1.77 KB, patch)
2014-07-07 20:08 UTC, Robert Schroll
committed Details | Review

Description Jim Nelson 2014-07-02 18:51:09 UTC
If there are too many recipients to fit on a single line in the inline composer (in compact mode), the text will ellipsize.  In that case, a tooltip should be available displaying all recipients.
Comment 1 Robert Schroll 2014-07-07 20:08:32 UTC
Created attachment 280088 [details] [review]
Add tooltip to compact composer header

The contacts are each on their own line, to avoid really wide tooltips.  
I've also prefixed each with its type (To, CC, BCC), since that's 
relevant information that isn't otherwise available.  It's a bit 
prominent, though; perhaps it should be lowercase? I wasn't sure about 
the translation -- should the colon be part of the translatable text or 
not?
Comment 2 Jim Nelson 2014-07-08 20:02:39 UTC
I dig it, I think it looks just about right.  Yes, the colon should be translatable since some languages may use a different separator (if they use one at all).

Two quibbles:

* We use "Cc:" and "Bcc:" consistently throughout the app, so we should use the same for the tooltip.

* We prefer to use to_string() for debugging and logging.  Instead, use RFC822.MailboxAddress.get_full_address() (which to_string() uses today).

Make these changes and commit!
Comment 3 Robert Schroll 2014-07-08 21:51:24 UTC
Attachment 280088 [details] pushed as 7c6aa35 - Add tooltip to compact composer header