After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732622 - The top edges of the fullscreen overlay are round
The top edges of the fullscreen overlay are round
Status: RESOLVED OBSOLETE
Product: gnome-boxes
Classification: Applications
Component: display
unspecified
Other Linux
: Low enhancement
: --
Assigned To: GNOME Boxes maintainer(s)
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-07-02 12:21 UTC by Lasse Schuirmann
Modified: 2018-01-11 10:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of the issue (1003 bytes, image/png)
2014-07-02 12:21 UTC, Lasse Schuirmann
Details
Screenshot of the non-issue (597.32 KB, image/png)
2014-07-02 16:03 UTC, Zeeshan Ali
Details

Description Lasse Schuirmann 2014-07-02 12:21:36 UTC
Created attachment 279746 [details]
Screenshot of the issue

See screenshot (I colored the background red. In reality its hard to notice it.)
Comment 1 Zeeshan Ali 2014-07-02 13:10:27 UTC
Yes? Thats intentional. We want round edges.
Comment 2 Lasse Schuirmann 2014-07-02 13:18:32 UTC
We want round edges on the top of the bar? For me it looks pretty weird: its a round thing tangent to the screen edge. It would make a lot more sense for me if its just an edge on the screen edge. Mutter does the same with the topbar of maximized windows on non-primary screens or half-screen sized windows (in this case its only one edge).
Comment 3 Zeeshan Ali 2014-07-02 13:24:19 UTC
(In reply to comment #2)
> We want round edges on the top of the bar? 

Ah so the bug is about that? Could you change the title to reflect that?
Comment 4 Zeeshan Ali 2014-07-02 16:03:01 UTC
Created attachment 279787 [details]
Screenshot of the non-issue

I don't see any rounded corners here. Your screenshot looks very much like older Boxes actually.
Comment 5 Zeeshan Ali 2014-07-02 16:04:50 UTC
I didn't even reproduce it against 3.12.2. Are you sure you mean the edges of topbar and not the button? You screenshot is just of a button.
Comment 6 Lasse Schuirmann 2014-07-02 16:14:36 UTC
I do mean the topbar. (I marked it red in my screenshot.) I did test this after playing around with your patches on the topbar. I was pretty sure I did test this on master but obviously something had gone wrong there because I can't reproduce it anymore on master and HEAD^^.

Sorry for the noise and thanks for the patience.
Comment 7 Lasse Schuirmann 2014-07-02 17:57:58 UTC
I just reproduced it. It just happens if I fullscreen directly from an unmaximized window (it's right if you do it from maximized state).

I tested this definitely on master and I don't think this has anything to do with the patches.
Comment 8 Zeeshan Ali 2014-07-02 19:07:48 UTC
hmm.. yeah I can reproduce it too. Weird!
Comment 9 Zeeshan Ali 2014-10-21 12:39:37 UTC
Can't reproduce anymore. Maybe some gtk+ glitch?
Comment 10 Lasse Schuirmann 2014-10-21 12:41:18 UTC
It occurs only if you're entering fullscreen state from non-maximized state. It is rendered alright if you enter from maximized state.
Comment 11 Zeeshan Ali 2014-10-21 13:00:48 UTC
(In reply to comment #10)
> It occurs only if you're entering fullscreen state from non-maximized state. It
> is rendered alright if you enter from maximized state.

Yeah, i tried that exactly. Can you still reproduce?
Comment 12 Lasse Schuirmann 2014-10-21 13:30:46 UTC
Yes I can. With current git master.
Comment 13 Zeeshan Ali 2014-10-21 14:28:37 UTC
(In reply to comment #12)
> Yes I can. With current git master.

Ah yes, I keep forgetting the issue is headerbar itself and not the button. :)

I have seen that totem has exactly the same issue. Could you please confirm? You can reproduce against 3.14 so no need to build totem in jhbuild.
Comment 14 Lasse Schuirmann 2014-10-21 14:32:40 UTC
(In reply to comment #13)
> (In reply to comment #12)
> > Yes I can. With current git master.
> 
> Ah yes, I keep forgetting the issue is headerbar itself and not the button. :)
> 
> I have seen that totem has exactly the same issue. Could you please confirm?
> You can reproduce against 3.14 so no need to build totem in jhbuild.

Confirmed.
Comment 15 Zeeshan Ali 2015-05-22 16:17:44 UTC
I can't reproduce this against 3.16/master. Could you please confirm?
Comment 16 Lasse Schuirmann 2015-05-22 16:21:57 UTC
I can reproduce on 3.16.
Comment 17 Felipe Borges 2017-03-01 13:21:18 UTC
I can still reproduce it against 3.23.91.1/master.

It seems like a GtkHeaderBar bug, as mentioned by Zeeshan before. Should we reassign it to gtk+?
Comment 18 GNOME Infrastructure Team 2018-01-11 10:09:16 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-boxes/issues/27.