After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732596 - gdppay: put all sticky events in streamheader
gdppay: put all sticky events in streamheader
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
unspecified
Other All
: Normal normal
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-01 23:42 UTC by Thiago Sousa Santos
Modified: 2014-07-22 12:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gdppay: put all sticky events in streamheader (18.05 KB, patch)
2014-07-01 23:42 UTC, Thiago Sousa Santos
committed Details | Review

Description Thiago Sousa Santos 2014-07-01 23:42:41 UTC
gdppay has a fixed list of stream-start, caps, segment, tags (optional) to be put on the stream headers. This patch makes it put all sticky events in the order stored in the pads (should be the same as above) as all sticky events can be considered as headers for the stream.

This should still keep it compatible with the GDP 1.0 version.
Comment 1 Thiago Sousa Santos 2014-07-01 23:42:44 UTC
Created attachment 279727 [details] [review]
gdppay: put all sticky events in streamheader

Use the sticky events to compose the streamheader as they are the
ones that are persisted to config new pads linked. Instead of storing
them ourselves rely on the pad storage that already orders it for us
Comment 2 Sebastian Dröge (slomo) 2014-07-02 08:54:32 UTC
Comment on attachment 279727 [details] [review]
gdppay: put all sticky events in streamheader

The code talks about newsegment still :) This really needs some further cleanup at some point.

Please push after 1.4.0 :)
Comment 3 Thiago Sousa Santos 2014-07-22 12:18:42 UTC
commit ea7b843244f3494a96b43d0a5dcaed69b8a5bf56
Author: Thiago Santos <ts.santos@sisa.samsung.com>
Date:   Tue Jul 1 10:07:40 2014 -0300

    gdppay: put all sticky events in streamheader
    
    Use the sticky events to compose the streamheader as they are the
    ones that are persisted to config new pads linked. Instead of storing
    them ourselves rely on the pad storage that already orders it for us
    
    https://bugzilla.gnome.org/show_bug.cgi?id=732596