GNOME Bugzilla – Bug 732585
[PATCH] prevent hardcoded Latin punctuation marks
Last modified: 2014-07-15 13:13:20 UTC
Our Arabic tester reported mixing of Arabic text and Latin punctuation mark (comma). The Latin comma is hardcoded and cannot be changed. Attached patch makes possible to translate comma, and also parentheses to the native script.
Missing patch?
Created attachment 279793 [details] [review] gnome-control-center-datetime-punctuation-i18n.patch
Review of attachment 279793 [details] [review]: ::: panels/datetime/cc-datetime-panel.c @@ +521,2 @@ country = gnome_get_country_from_code (loc->country, NULL); + /* Translators: "city, country", use comma specific for your language */ You can remove the "use ... for your language" in all the comments. @@ +550,2 @@ /* Update the timezone on the listbow row */ + /* Translators: "timezone (details)", use parentheses specific for your language */ Ditto. @@ +573,2 @@ /* Update the text bubble in the timezone map */ + /* Translators: "timezone (detals)\ncity\ntime, use parentheses Ditto and typo. @@ +573,3 @@ /* Update the text bubble in the timezone map */ + /* Translators: "timezone (detals)\ncity\ntime, use parentheses + * specific for your language, do not translate html tags */ They're not HTML tags, and this should be fixed properly.
Created attachment 280527 [details] [review] gnome-control-center-datetime-punctuation-i18n.patch New version of the patch. This is a super-safe version of the patch, that allows different "translations" of parentheses of "timezone (details)" and "timezone (utc shift)".
Created attachment 280529 [details] [review] gnome-control-center-datetime-punctuation-i18n-nocontext.patch Maybe, that the use of context is an overkill here. Here is a simplified version that allows just a single translation of "%s (%s)".
Created attachment 280530 [details] [review] gnome-control-center-datetime-punctuation-i18n-force-context.patch But looking at other places of code, it uses context for similar strings. Here is a third version of the patch, that forces context for all three strings.
Review of attachment 280527 [details] [review]: That looks fine, apart from the commit subject.
Review of attachment 280529 [details] [review]: It really needs both context and comments.
Review of attachment 280530 [details] [review]: That's probably the one we want.
Review of attachment 280527 [details] [review]: Rejected in favour of the third patch.
Fixed in master for GNOME 3.14. Thanks!