After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732559 - identity: Should proxy accept-caps query
identity: Should proxy accept-caps query
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
1.3.90
Other Linux
: Normal blocker
: 1.3.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-01 15:33 UTC by Jake Foytik
Modified: 2014-07-04 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jake Foytik 2014-07-01 15:33:20 UTC
Problem: When trying to record from an h264 rtsp stream, I get 'Internal data flow' errors for pipelines that worked in previous versions of gstreamer.

The following pipeline posts an 'Internal data flow error' after running the following pipeline with gst-launch : 
 - rtspsrc ! rtph264depay ! identity ! h264parse ! matroskamux ! fakesink
This pipeline does not work in v1.3.90, but does work in v1.2.4.

However, if the identity element is removed or placed after h264parse, the pipeline functions properly
 eg. - rtspsrc ! rtph264depay ! h264parse ! identity ! matroskamux ! fakesink

Also, if matroskamux is taken out of the pipeline, the identity element can be placed anywhere and the pipeline will function properly.
Comment 1 Sebastian Dröge (slomo) 2014-07-01 15:52:20 UTC
We had the same bug in aacparse at some point. Let's fix it :)
Comment 2 Sebastian Dröge (slomo) 2014-07-01 15:55:00 UTC
Actually it's the same bug one element further. See bug #705024 for details.
Comment 3 Gwenole Beauchesne 2014-07-01 15:55:43 UTC
(In reply to comment #1)
> We had the same bug in aacparse at some point. Let's fix it :)

It would be awesome if we could also fix bug #732239 along the way. :)
(somewhat more complex though)
Comment 4 Sebastian Dröge (slomo) 2014-07-01 17:20:28 UTC
commit b5936efc9866eb1a171247150c28d18f874b5718
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue Jul 1 19:17:11 2014 +0200

    identity: Proxy the accept-caps query
    
    We always work in passthrough mode so there's no point in doing
    something more clever in basetransform. Also the basetransform
    code leads to problems with incomplete caps and downstream
    elements that use GST_PAD_FLAG_ACCEPT_INTERSECT.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=732559
Comment 5 Jake Foytik 2014-07-01 19:20:46 UTC
That resolved it. Thanks for the fix :)