After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732540 - basesink: reset QoS on segment event
basesink: reset QoS on segment event
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.3.91
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-07-01 10:24 UTC by Vincent Penquerc'h
Modified: 2014-07-04 12:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
basesink: reset QoS on segment event (944 bytes, patch)
2014-07-01 10:24 UTC, Vincent Penquerc'h 		committed Details | Review
videomixer: reset QoS on segment event (824 bytes, patch)
2014-07-01 11:53 UTC, Vincent Penquerc'h 		committed Details | Review
videoaggregator: reset QoS on segment event (874 bytes, patch)
2014-07-01 11:55 UTC, Vincent Penquerc'h 		committed Details | Review

Description Vincent Penquerc'h 2014-07-01 10:24:38 UTC 
Created attachment 279663 [details] [review]
basesink: reset QoS on segment event

This avoids spurious warnings about slow machine when upstream
sends new segments without flushing.
Comment 1 Sebastian Dröge (slomo) 2014-07-01 11:15:09 UTC 
Comment on attachment 279663 [details] [review]
basesink: reset QoS on segment event

Looks good, but the same should be done for other elements too. Right now I remember QoS logic like this in deinterlace and GstVideoDecoder
Comment 2 Vincent Penquerc'h 2014-07-01 11:53:34 UTC 
Created attachment 279668 [details] [review]
videomixer: reset QoS on segment event
Comment 3 Vincent Penquerc'h 2014-07-01 11:55:01 UTC 
Created attachment 279669 [details] [review]
videoaggregator: reset QoS on segment event
Comment 4 Vincent Penquerc'h 2014-07-01 11:55:46 UTC 
That seems to be those. Some other plugins in -good were already resetting QoS data on segment events.