GNOME Bugzilla – Bug 732528
Attach the navigation bar to the bottom of the window
Last modified: 2015-12-03 18:56:11 UTC
The navigation bar - which contains skip, play, pause, and the seek bar - currently floats over the playing video. This made sense in the original design, as the seek bar was intended be much narrower than it currently is (see [1]). Since the navigation and seek bars are currently very wide, there is little point in having the navigation bar float over the playing video. In actual fact, it is worse, since it means that the bar obscures more of the interesting part of the video beneath. A good solution would be to attach the navigation bar to the bottom of the window (while still having it appear over the video, with a semi-transparent style). [1] https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/videos/videos-fullscreen.png
Created attachment 291982 [details] [review] backend: Remove margin around the navigation bar
Created attachment 291985 [details] Screenshot
Looks great! Only one issue I can see - the bar still has rounded corners.
I really don't think it's useful. I prefer the look of the navigation bar slightly centred, and I really don't want to be moving the bar if it's not going to be fittsy.
(In reply to comment #4) > I really don't think it's useful. I prefer the look of the navigation bar > slightly centred, and I really don't want to be moving the bar if it's not > going to be fittsy. I don't see why this has to be a requirement. I described advantages to this change in the original bug report, which should be sufficient to make it worthwhile. As far as the "look" goes, the vast majority of video players attach their navigation controls to the bottom of the view, and a lot of them look pretty good. In totem's case, a few small changes would improve appearance a lot, like being consistent with button relief, and adding a bit more padding around the seek bar and times.
(In reply to comment #0) > The navigation bar - which contains skip, play, pause, and the seek bar - > currently floats over the playing video. This made sense in the original > design, as the seek bar was intended be much narrower than it currently is (see > [1]). FWIW, that's the design I was using: https://wiki.gnome.org/Design/Apps/Videos#Tentative_Design Which has a wider seek bar. > Since the navigation and seek bars are currently very wide, there is little > point in having the navigation bar float over the playing video. In actual > fact, it is worse, since it means that the bar obscures more of the interesting > part of the video beneath. I doubt that the video at the bottom right and bottom left of the video are *that* interesting. > A good solution would be to attach the navigation bar to the bottom of the > window (while still having it appear over the video, with a semi-transparent > style). > > [1] > https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/videos/videos-fullscreen.png (In reply to comment #5) > (In reply to comment #4) > > I really don't think it's useful. I prefer the look of the navigation bar > > slightly centred, and I really don't want to be moving the bar if it's not > > going to be fittsy. > > I don't see why this has to be a requirement. I described advantages to this > change in the original bug report, which should be sufficient to make it > worthwhile. The only advantage I can read is "it obscures more of the video". It obscure more of uninteresting parts of the video. > As far as the "look" goes, the vast majority of video players attach their > navigation controls to the bottom of the view, That seems to be mostly because of technical reasons, or space constraints. iOS doesn't do that on either phone or tablet. Do you have examples of first-party video players that do that? > and a lot of them look pretty > good. In totem's case, a few small changes would improve appearance a lot, like > being consistent with button relief, We just apply the OSD style, nothing more. > and adding a bit more padding around the > seek bar and times.
Review of attachment 291982 [details] [review]: You could also remove all instances of the CONTROLS_MARGIN constant. Note that we also need to figure out how to remove the rounded corners.
I'd need positional style classes (top/bottom/left/right) to make the style looks ok (read no rounded corners in this case), so if you add, say a "bottom" styleclass there, I'll change adwaita accordingly.
*** Bug 728442 has been marked as a duplicate of this bug. ***
Created attachment 316734 [details] [review] backend: Remove margins from the controls OSD This will be style as a square area running to the edges with newer versions of GTK+: https://git.gnome.org/browse/gtk+/commit/?id=07ee962ed34ad87138b99f8c7e86f84452f17e14
Attachment 316734 [details] pushed as 45ee3a4 - backend: Remove margins from the controls OSD