After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 732460 - girparser: Instance method detection broken
girparser: Instance method detection broken
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
0.24.x
Other Linux
: Normal major
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks: 775812
 
 
Reported: 2014-06-30 08:13 UTC by Simon Werbeck
Modified: 2018-01-09 16:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
girparser: Fix instance method detection (1.47 KB, patch)
2014-06-30 08:13 UTC, Simon Werbeck 		none Details | Review
girparser: Improve instance method detection (1.86 KB, patch)
2016-09-27 20:55 UTC, Rico Tzschichholz 		committed Details | Review

Description Simon Werbeck 2014-06-30 08:13:51 UTC 
Created attachment 279579 [details] [review]
girparser: Fix instance method detection

The code for detecting instance methods is broken, instead they are picked up as static methods.
I attached fix, but of course this breaks API and I don't see how we could deprecate the old behavior. On the other hand, some bindings like for example gobject-introspection are pretty much unusable without this patch so any suggestions for improving it are appreciated.
Comment 1 Rico Tzschichholz 2016-09-27 20:55:58 UTC 
Created attachment 336389 [details] [review]
girparser: Improve instance method detection

Improve reparenting static namespace functions to their presumably parent
structures. Only allow this if the first parameter is not defined as (out)
or (inout)

Unfortunately, while this patch fixes detection, nothing can be done about
breaking API.

Based on patch by Simon Werbeck <simon.werbeck@gmail.com>
Comment 2 Rico Tzschichholz 2016-09-27 20:58:08 UTC 
Pushed to https://git.gnome.org/browse/vala/log/?h=wip/girparser followed by a regen of gir-bindings.
Comment 3 Rico Tzschichholz 2018-01-09 16:40:19 UTC 
Attachment 336389 [details] pushed as 1fdaa35 - girparser: Improve instance method detection